mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-29 19:21:01 +00:00
bb0255b2fb
Enabling the configuration option should have no negative impact on how the tool behaves. There is no topology and we do not create any keyspaces (except for trivial ones using `SimpleStrategy` and RF=1), only their metadata. Thanks to that, we don't go through validation logic that could fail in presence of an RF-rack-invalid keyspace. On the other hand, enabling `rf_rack_valid_keyspaces` lets the tool access code hidden behind that option. While that might not be of any consequence right now, in the future it might be crucial (for instance, see: scylladb/scylladb#23030). Note that other tools don't need an adjustment: * scylla-types: it uses schema_builder, but it doesn't reuse any other relevant part of Scylla. * nodetool: it manages Scylla instances but is not an instance itself, and it does not reuse any codepaths. * local-file-key-generator: it has nothing to do with Scylla's logic. Other files in the `tools` directory are auxiliary and are instructed with an already created instance of `db::config`. Hence, no need to modify them either. Fixes scylladb/scylladb#25792 Closes scylladb/scylladb#25794