scylladb

mirror of https://github.com/scylladb/scylladb.git synced 2026-04-24 10:30:38 +00:00

Files

Raphael S. Carvalho 71ec750a59 replica: Fix use-after-move in table::make_streaming_reader

Variant used by
streaming/stream_transfer_task.cc:        , reader(cf.make_streaming_reader(cf.schema(), std::move(permit_), prs))

as full slice is retrieved after schema is moved (clang evaluates
left-to-right), the stream transfer task can be potentially working
on a stale slice for a particular set of partitions.

static report:
In file included from replica/dirty_memory_manager.cc:6:
replica/database.hh:706:83: error: invalid invocation of method 'operator->' on object 'schema' while it is in the 'consumed' state [-Werror,-Wconsumed]
        return make_streaming_reader(std::move(schema), std::move(permit), range, schema->full_slice());

Fixes #13397.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
(cherry picked from commit 04932a66d3)

2023-05-15 20:21:48 +03:00

compaction_group.hh

replica: table: Rework compaction triggers for compaction groups

2022-12-19 11:16:07 -03:00

data_dictionary_impl.hh

data_dictonary: add get_all_keyspaces() and get_user_keyspaces()

2022-12-10 12:51:05 +01:00

database_fwd.hh

memtable: move to replica module and namespace

2022-02-23 09:05:16 +02:00

database.cc

Merge 'Improve database shutdown verbosity' from Pavel Emelyanov