Gleb Natapov 1a9aaece3e cql_server: fix a race between closing of a connection and notifier registration ...

There is a race between cql connection closure and notifier
registration. If a connection is closed before notification registration
is complete stale pointer to the connection will remain in notification
list since attempt to unregister the connection will happen to early.
The fix is to move notifier unregisteration after connection's gate
is closed which will ensure that there is no outstanding registration
request. But this means that now a connection with closed gate can be in
notifier list, so with_gate() may throw and abort a notifier loop. Fix
that by replacing with_gate() by call to is_closed();

Fixes: #3355
Tests: unit(release)

Message-Id: <20180412134744.GB22593@scylladb.com>

2018-04-12 16:56:50 +03:00

..

messages

Merge seatar upstream (seastar namespace)

2017-05-21 12:26:15 +03:00

event_notifier.cc

cql_server: fix a race between closing of a connection and notifier registration

2018-04-12 16:56:50 +03:00

event.cc

Merge seatar upstream (seastar namespace)

2017-05-21 12:26:15 +03:00

event.hh

Merge seatar upstream (seastar namespace)

2017-05-21 12:26:15 +03:00

messages_fwd.hh

Merge seatar upstream (seastar namespace)

2017-05-21 12:26:15 +03:00

server.cc

cql_server: fix a race between closing of a connection and notifier registration

2018-04-12 16:56:50 +03:00

server.hh

transport::cql_server::process_request_one: return only the required information instead of the whole client_state object

2018-01-15 13:09:57 -05:00