scylladb

Files

Patryk Jędrzejczak a41d7a9240 Merge 'test_lwt_shutdown: fix flakiness by removing storage_proxy::stop injection' from Petr Gusev

The storage_proxy::stop() is not called by main (it is commented out due to #293), so the corresponding message injection is never hit. When the test releases paxos_state_learn_after_mutate, shutdown may already be in progress or even completed by the time we try to trigger the storage_proxy::stop injection, which makes the test flaky.

Fix this by completely removing the storage_proxy::stop injection. The injection is not required for test correctness. Shutdown must wait for the background LWT learn to finish, which is released via the paxos_state_learn_after_mutate injection. The shutdown process blocks on in-flight HTTP requests through seastar::httpd::http_server::stop and its _task_gate, so the HTTP request that releases paxos_state_learn_after_mutate is guaranteed to complete before the node is shut down.

Fixes scylladb/scylladb#28260

backport: 2025.4, the `test_lwt_shutdown` test was introduced in this version

Closes scylladb/scylladb#28315

* https://github.com/scylladb/scylladb:
  storage_proxy: drop stop() method
  test_lwt_shutdown: fix flakiness by removing storage_proxy::stop injection

2026-01-23 15:18:17 +01:00

auth_cluster

test: check cql_requests_count instead of tasks_processed in SL

2026-01-23 10:19:29 +01:00

dtest

test/cluster/dtest: remove is_win() and users

2026-01-19 12:56:57 +02:00

lwt

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

topology_coordinator, storage_service: Validate node removal/decommission at request submission time

2026-01-18 15:36:04 +01:00

object_store

reduce test_backup.py and test_refresh.py datasets

2026-01-21 10:47:36 +02:00

random_failures

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

tasks

tasks, topology: Make pending node operations abortable

2026-01-18 15:36:05 +01:00

__init__.py

…

conftest.py

test.py: fix the link for the failed_test directory

2026-01-13 10:22:38 +02:00

suite.yaml

test: dtest: reproducer for parallel rebuild failure

2026-01-08 21:55:18 +02:00

test_aggregation.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_alternator_proxy_protocol.py

alternator: add optional listeners for proxy protocol v2

2026-01-13 09:59:24 +02:00

test_alternator.py

alternator: don't require rf_rack flag for indexes, validate instead

2026-01-22 16:11:35 +01:00

test_automatic_cleanup.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_bad_initial_token.py

…

test_batchlog_manager.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_blocked_bootstrap.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_boot_after_ip_change.py

…

test_boot_nodes.py

…

test_bti_index.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_cdc_generation_clearing.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_cdc_generation_data.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_cdc_generation_publishing.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_cdc_with_alter.py

test: test concurrent writes with column drop with cdc preimage

2025-11-13 17:00:08 +01:00

test_cdc_with_tablets.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_change_ip.py

test.py: add pid to ServerInfo

2025-12-12 15:11:03 +02:00

test_change_replication_factor_1_to_0.py

test: cluster: deflake consistency checks after decommission

2025-09-09 19:01:12 +02:00

test_change_rpc_address.py

…

test_client_routes.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_cluster_features.py

test: test_downgrade_after_partial_upgrade: check that feature is disabled on all nodes after partial upgrade

2025-12-30 17:34:56 +01:00

test_commitlog_segment_data_resurrection.py

…

test_commitlog.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_concurrent_schema.py

…

test_config_live_updates.py

…

test_config.py

…

test_conflicting_keys_read_repair.py

…

test_coordinator_queue_management.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_counter_write_timeout_metric.py

storage_proxy: mark write_timeouts metric for counter write timeouts

2026-01-14 17:50:46 +02:00

test_counters_with_tablets.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_crash_coordinator_before_streaming.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_create_table_during_node_shutdown.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_data_resurrection_after_cleanup.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_data_resurrection_in_memtable.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_decommission_kill_then_replace.py

topology coordinator: complete pending operation for a replaced node

2026-01-14 13:11:27 +01:00

test_decommission.py

test: cluster: deflake consistency checks after decommission

2025-09-09 19:01:12 +02:00

test_deprecating_cluster_features.py

…

test_describe.py

…

test_different_group0_ids.py

Revert "db/config: don't use RBNO for scaling"

2025-11-18 08:17:17 +02:00

test_encryption.py

test_encryption: capture stderr

2026-01-21 14:56:01 +01:00

test_error_becoming_voter.py

…

test_fencing.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_global_ignore_nodes.py

…

test_gossip_boot.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_gossiper_empty_self_id_on_shadow_round.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_gossiper_orphan_remover.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_gossiper_race.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_gossiper.py

…

test_group0_recovers_after_partial_command_application.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_group0_schema_versioning.py

test: test_group0_schema_versioning: wait for schema sync in system.local

2026-01-14 09:55:45 +01:00

test_hints.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_incremental_repair.py

Revert "api: storage_service/tablets/repair: disable incremental repair by default"

2026-01-21 08:50:13 +02:00

test_initial_token.py

…

test_internode_compression.py

test/cluster/test_internode_compression: Transpose test from dtest

2026-01-14 10:53:34 +01:00

test_ip_mappings.py

gossiper: add_saved_endpoint: make generations of excluded nodes negative

2025-12-29 19:13:55 +01:00

test_keyspace_rf.py

test: Generalize tests to work with both numeric RF and rack lists

2025-10-29 23:32:58 +01:00

test_left_node_notification.py

raft topology: Notify that a node was removed only once

2025-12-29 14:22:34 +01:00

test_long_join.py

test: improve async execution in test_long_join

2025-09-08 17:14:37 +02:00

test_long_query_timeout_erm.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_lwt_semaphore.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_maintenance_mode.py

test/cluster/test_maintenance_mode.py: Wait for initialization

2025-11-13 11:07:45 +01:00

test_major_compaction.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_metadata_id.py

…

test_multidc.py

db: fail reads and writes with local consistencty level to a DC with RF=0

2026-01-22 12:49:45 +01:00

test_mutation_schema_change.py

…

test_mv.py

tombstone_gc: don't use 'repair' mode for colocated tables

2025-11-25 09:15:46 +01:00

test_no_dc_rack_change.py

…

test_no_removed_node_event_on_ip_change.py

test.py: add pid to ServerInfo

2025-12-12 15:11:03 +02:00

test_node_isolation.py

topology: let banned node know that it is banned

2025-11-24 17:12:13 +01:00

test_node_ops_metrics.py

…

test_node_shutdown_waits_for_pending_requests.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_nodetool.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_not_enough_token_owners.py

test: cluster: Fix NoHostAvailable error in test_not_enough_token_owners

2026-01-08 21:53:47 +02:00

test_proxy_protocol.py

test: test_proxy_protocol: bump timeout

2026-01-23 15:37:00 +02:00

test_query_rebounce.py

…

test_raft_cluster_features.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_raft_fix_broken_snapshot.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_raft_ignore_nodes.py

…

test_raft_no_quorum.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_raft_recovery_basic.py

…

test_raft_recovery_during_join.py

test: test_raft_recovery_during_join: get host ID of the bootstrapping node before it crashes

2026-01-22 06:55:16 +02:00

test_raft_recovery_entry_loss.py

test: unskip test_raft_recovery_entry_loss

2025-10-24 21:23:41 +03:00

test_raft_recovery_majority_loss.py

…

test_raft_recovery_stuck.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_raft_recovery_user_data.py

test: test_raft_recovery_user_data: prevent repeated ALTER KEYSPACE request

2026-01-22 14:13:42 +03:00

test_raft_snapshot_request.py

…

test_raft_snapshot_truncation.py

…

test_raft_voters.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_random_tables.py

…

test_read_repair.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_refresh.py

reduce test_backup.py and test_refresh.py datasets

2026-01-21 10:47:36 +02:00

test_remove_alive_node.py

…

test_remove_rpc_client_with_pending_requests.py

…

test_repair.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_replace_alive_node.py

…

test_replace_ignore_nodes.py

…

test_replace_with_encryption.py

…

test_replace_with_same_ip_twice.py

…

test_replace.py

…

test_replica_exceptions.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_rest_api_on_startup.py

test: add test_rest_api_on_startup

2025-12-03 15:35:59 +01:00

test_restart_cluster.py

…

test_resurrection.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_reversed_queries_during_simulated_upgrade_process.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_rpc_compression.py

…

test_select_from_mutation_fragments.py

…

test_shutdown_hang.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_size_based_load_balancing.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_snapshot.py

…

test_sstable_cleanup_stop.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_sstable_compression_config.py

schema: Add initializer for compression defaults

2026-01-13 20:45:59 +02:00

test_sstable_compression_dictionaries_autotrain.py

…

test_sstable_compression_dictionaries_basic.py

db/config: Deprecate sstable_compression_dictionaries_allow_in_ddl

2025-10-29 20:13:08 +02:00

test_sstable_compression_dictionaries_upgrade.py

pylib: extract upgrade helpers from test_sstable_compression_dictionaries_upgrade.py

2025-09-15 12:34:45 +02:00

test_sstable_set.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_start_bootstrapped_with_invalid_seed.py

test: disable test_start_bootstrapped_with_invalid_seed

2026-01-15 10:25:45 +01:00

test_streaming_deadlock.py

test: limit test_streaming_deadlock_removenode concurrency

2025-09-19 12:50:20 +03:00

test_strong_consistency.py

test/cluster: add test_strong_consistency.py

2026-01-21 14:56:01 +01:00

test_table_desc_read_barrier.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_table_drop.py

…

test_tablet_repair_scheduler.py

repair: Implement auto repair for tablet repair

2026-01-09 16:11:39 +08:00

test_tablet_stats.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_tablets2.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_tablets_colocation.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_tablets_cql.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_tablets_intranode.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_tablets_lwt.py

test_lwt_shutdown: fix flakiness by removing storage_proxy::stop injection

2026-01-23 11:20:36 +01:00

test_tablets_merge.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_tablets_migration.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_tablets_parallel_decommission.py

test: Add tests for parallel decommission/removenode

2026-01-18 15:36:08 +01:00

test_tablets_removenode.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_tablets.py

Merge 'raft_topology, tablets: Drain tablets in parallel with other topology operations' from Tomasz Grabiec

2026-01-22 13:06:53 +01:00

test_tls.py

…

test_tombstone_gc.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_topology_failure_recovery.py

topology_coordinator, tablets: Fail draining operations when tablet migration fails due to critical disk utilization

2026-01-18 15:36:07 +01:00

test_topology_ops_encrypted.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_topology_ops_with_rf_rack_valid.py

topology_coordinator, storage_service: Validate node removal/decommission at request submission time

2026-01-18 15:36:04 +01:00

test_topology_ops.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_topology_recovery_basic.py

test.py: apply the nightly label on test_topology_recovery_basic

2025-09-01 14:16:29 +02:00

test_topology_recovery_majority_loss.py

…

test_topology_rejoin.py

…

test_topology_remove_decom.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_topology_remove_garbage_group0.py

…

test_topology_schema.py

…

test_topology_smp.py

…

test_topology_upgrade_not_stuck_after_recent_removal.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_topology_upgrade_stuck.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_topology_upgrade.py

…

test_truncate_concurrent_writes.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_truncate_with_drop.py

system_keyspace: Prune dropped tables from truncation on start/drop

2025-09-03 07:25:34 +03:00

test_truncate_with_tablets.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_unfinished_writes_during_shutdown.py

Merge 'topology coordinator: restrict node join/remove to preserve RF-rack validity' from Michael Litvak

2026-01-09 10:01:23 +02:00

test_vector_store.py

index: allow vector indexes without rf_rack_valid_keyspces

2025-12-05 09:26:26 +02:00

test_view_build_status.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_view_building_coordinator.py

test: Use ManagerClient.{disable,enable}_tablet_balancing()

2026-01-13 00:38:00 +01:00

test_write_query_during_cql_server_shutdown.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_writes_to_previous_cdc_generations.py

test.py: convert skip_mode function to pytest.mark

2026-01-08 21:55:16 +02:00

test_zero_token_nodes_multidc.py

test: test_zero_token_nodes_multidc: properly handle reads with CL=LOCAL_ONE

2026-01-21 15:17:42 +01:00

test_zero_token_nodes_no_replication.py

…

test_zero_token_nodes_topology_ops.py

…

util.py

test: util: Introduce ensure_group0_leader_on()

2026-01-18 15:36:07 +01:00