mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-24 18:40:38 +00:00
b34a1d9576
" Issue https://github.com/scylladb/scylla/issues/7019 describes a problem of an ever-growing map of temporary values stored in query_options. In order to mitigate this kind of problems, the storage for temporary values is moved from an external data structure to the value views itself. This way, the temporary lives only as long as it's accessible and is automatically destroyed once a request finishes. The downside is that each temporary is now allocated separately, while previously they were bundled in a single byte stream. Tests: unit(dev) Fixes https://github.com/scylladb/scylla/issues/7019 "7055297649("cql3: remove query_options::linearize and _temporaries") is reverted from this backport since linearize() is still used in this branch. * psarna-move_temporaries_to_value_view: cql3: remove query_options::linearize and _temporaries cql3: remove make_temporary helper function cql3: store temporaries in-place instead of in query_options cql3: add temporary_value to value view cql3: allow moving data out of raw_value cql3: split values.hh into a .cc file (cherry picked from commit2b308a973f)
70 lines
2.1 KiB
C++
70 lines
2.1 KiB
C++
/*
|
|
* Copyright (C) 2020 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "cql3/values.hh"
|
|
|
|
namespace cql3 {
|
|
|
|
std::ostream& operator<<(std::ostream& os, const raw_value_view& value) {
|
|
seastar::visit(value._data, [&] (fragmented_temporary_buffer::view v) {
|
|
os << "{ value: ";
|
|
using boost::range::for_each;
|
|
for_each(v, [&os] (bytes_view bv) { os << bv; });
|
|
os << " }";
|
|
}, [&] (null_value) {
|
|
os << "{ null }";
|
|
}, [&] (unset_value) {
|
|
os << "{ unset }";
|
|
});
|
|
return os;
|
|
}
|
|
|
|
raw_value_view raw_value::to_view() const {
|
|
switch (_data.index()) {
|
|
case 0: return raw_value_view::make_value(fragmented_temporary_buffer::view(bytes_view{std::get<bytes>(_data)}));
|
|
case 1: return raw_value_view::make_null();
|
|
default: return raw_value_view::make_unset_value();
|
|
}
|
|
}
|
|
|
|
raw_value raw_value::make_value(const raw_value_view& view) {
|
|
if (view.is_null()) {
|
|
return make_null();
|
|
}
|
|
if (view.is_unset_value()) {
|
|
return make_unset_value();
|
|
}
|
|
return make_value(linearized(*view));
|
|
}
|
|
|
|
raw_value_view raw_value_view::make_temporary(raw_value&& value) {
|
|
if (!value) {
|
|
return raw_value_view::make_null();
|
|
}
|
|
return raw_value_view(std::move(value).extract_value());
|
|
}
|
|
|
|
raw_value_view::raw_value_view(bytes&& tmp) {
|
|
_temporary_storage = make_lw_shared<bytes>(std::move(tmp));
|
|
_data = fragmented_temporary_buffer::view(bytes_view(*_temporary_storage));
|
|
}
|
|
|
|
} |