mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-01 21:55:50 +00:00
" Garbage collected SSTables, created by incremental compaction process, are being added to the SSTable set using a function that invalidates row cache using the range of the SSTable itself. That's incorrect because data in GC SSTables come from preexisting SSTables in set, meaning the state of data isn't changed and so no need for invalidation at all. Incorrect invalidation like this is a source of read performance issues. This problem is fixed by including GC SSTables to the descriptor which is used to specify changes to the SSTable set, which is the correct thing to do given that a midway failure could leave the set in an incorrect state. Fixes #5956. Fixes #6275. tests: unit(dev) " * 'fix_issue_5956_v4' of github.com:raphaelsc/scylla: sstables/compaction: Don't invalidate row cache when adding GC SSTable to SSTable set sstables/compaction: Change meaning of compaction_completion_desc input and output fields sstables/compaction: Clean up code around garbage_collected_sstable_writer