This reverts commit31c6a794e9, reversing changes made to4537ec7426. It causes bad_function_calls in some situations: INFO 2019-01-20 01:41:12,164 [shard 0] database - Keyspace system: Reading CF sstable_activity id=5a1ff267-ace0-3f12-8563-cfae6103c65e version=d69820df-9d03-3cd0-91b0-c078c030b708 INFO 2019-01-20 01:41:13,952 [shard 0] legacy_schema_migrator - Moving 0 keyspaces from legacy schema tables to the new schema keyspace (system_schema) INFO 2019-01-20 01:41:13,958 [shard 0] legacy_schema_migrator - Dropping legacy schema tables INFO 2019-01-20 01:41:14,702 [shard 0] legacy_schema_migrator - Completed migration of legacy schema tables ERROR 2019-01-20 01:41:14,999 [shard 0] seastar - Exiting on unhandled exception: std::bad_function_call (bad_function_call)
202 lines
6.5 KiB
C++
202 lines
6.5 KiB
C++
/*
|
|
* Copyright 2015 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
#include <random>
|
|
#include <bitset>
|
|
#include <boost/test/unit_test.hpp>
|
|
#include <boost/range/irange.hpp>
|
|
#include <seastar/core/semaphore.hh>
|
|
#include <seastar/core/reactor.hh>
|
|
#include <seastar/core/thread.hh>
|
|
|
|
#include "seastarx.hh"
|
|
#include "tests/test-utils.hh"
|
|
#include "utils/flush_queue.hh"
|
|
#include "log.hh"
|
|
|
|
std::random_device rd;
|
|
std::default_random_engine e1(rd());
|
|
|
|
SEASTAR_TEST_CASE(test_queue_ordering_random_ops) {
|
|
struct env {
|
|
env(size_t n) : promises(n) {}
|
|
|
|
utils::flush_queue<int> queue;
|
|
std::vector<promise<>> promises;
|
|
std::vector<int> result;
|
|
};
|
|
|
|
auto r = boost::irange(0, 100);
|
|
|
|
return do_for_each(r, [](int) {
|
|
constexpr size_t num_ops = 1000;
|
|
|
|
auto e = make_lw_shared<env>(num_ops);
|
|
|
|
int i = 0;
|
|
for (auto& p : e->promises) {
|
|
e->queue.run_with_ordered_post_op(i, [&p, i] {
|
|
return p.get_future().then([i] {
|
|
return make_ready_future<int>(i);
|
|
});
|
|
}, [e](int i) {
|
|
e->result.emplace_back(i);
|
|
});
|
|
++i;
|
|
}
|
|
|
|
auto res = e->queue.wait_for_pending();
|
|
|
|
std::uniform_int_distribution<size_t> dist(0, num_ops - 1);
|
|
std::bitset<num_ops> set;
|
|
|
|
while (!set.all()) {
|
|
size_t i = dist(e1);
|
|
if (!set.test(i)) {
|
|
set[i] = true;
|
|
e->promises[i].set_value();
|
|
}
|
|
}
|
|
|
|
return res.then([e] {
|
|
BOOST_CHECK_EQUAL(e->result.size(), e->promises.size());
|
|
BOOST_REQUIRE(std::is_sorted(e->result.begin(), e->result.end()));
|
|
}).finally([e] {
|
|
return e->queue.close().finally([e] { });
|
|
});
|
|
});
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_queue_ordering_multi_ops) {
|
|
struct env {
|
|
env() : sem(0) {}
|
|
|
|
utils::flush_queue<int> queue;
|
|
std::vector<int> result;
|
|
semaphore sem;
|
|
size_t n = 0;
|
|
};
|
|
|
|
auto r = boost::irange(0, 100);
|
|
|
|
return do_for_each(r, [](int) {
|
|
constexpr size_t num_ops = 1000;
|
|
|
|
auto e = make_lw_shared<env>();
|
|
|
|
std::uniform_int_distribution<size_t> dist(0, num_ops - 1);
|
|
|
|
for (size_t k = 0; k < num_ops*10; ++k) {
|
|
int i = dist(e1);
|
|
|
|
if (e->queue.has_operation(i) || (!e->queue.empty() && e->queue.highest_key() < i)) {
|
|
e->queue.run_with_ordered_post_op(i, [e, i] {
|
|
return e->sem.wait().then([i] {
|
|
return make_ready_future<int>(i);
|
|
});
|
|
}, [e](int i) {
|
|
e->result.emplace_back(i);
|
|
});
|
|
++e->n;
|
|
}
|
|
}
|
|
|
|
auto res = e->queue.wait_for_pending();
|
|
|
|
e->sem.signal(e->n);
|
|
|
|
return res.then([e] {
|
|
BOOST_CHECK_EQUAL(e->result.size(), e->n);
|
|
BOOST_REQUIRE(std::is_sorted(e->result.begin(), e->result.end()));
|
|
}).finally([e] {
|
|
return e->queue.close().finally([e] { });
|
|
});
|
|
});
|
|
}
|
|
|
|
template<typename Func, typename Post, typename Then>
|
|
static future<> test_propagation(bool propagate, Func&& func, Post&& post, Then&& thn, bool want_except_in_run, bool want_except_in_wait) {
|
|
auto queue = ::make_shared<utils::flush_queue<int>>(propagate);
|
|
auto sem = ::make_shared<semaphore>(0);
|
|
auto xr = ::make_shared<bool>(false);
|
|
auto xw = ::make_shared<bool>(false);
|
|
|
|
auto f1 = queue->run_with_ordered_post_op(0, [sem, func = std::forward<Func>(func)]() mutable {
|
|
return sem->wait().then(std::forward<Func>(func));
|
|
}, std::forward<Post>(post)).handle_exception([xr](auto p) {
|
|
*xr = true;
|
|
}).discard_result();
|
|
|
|
auto f2 = queue->wait_for_pending(0).then(std::forward<Then>(thn)).handle_exception([xw](auto p) {
|
|
*xw = true;
|
|
}).discard_result();
|
|
|
|
sem->signal();
|
|
|
|
return seastar::when_all_succeed(std::move(f1), std::move(f2)).finally([sem, queue, want_except_in_run, want_except_in_wait, xr, xw] {
|
|
BOOST_CHECK_EQUAL(want_except_in_run, *xr);
|
|
BOOST_CHECK_EQUAL(want_except_in_wait, *xw);
|
|
}).finally([queue] {
|
|
return queue->close().finally([queue] { });
|
|
});
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_propagate_exception_in_op) {
|
|
return test_propagation(true, // propagate exception to waiter
|
|
[] { return make_exception_future(std::runtime_error("hej")); }, // ex in op
|
|
[] { BOOST_FAIL("should not reach (1)"); }, // should not reach post
|
|
[] { BOOST_FAIL("should not reach (2)"); }, // should not reach waiter "then"
|
|
true,
|
|
true
|
|
);
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_propagate_exception_in_post) {
|
|
return test_propagation(true, // propagate exception to waiter
|
|
[] {}, // ok func
|
|
[] { return make_exception_future(std::runtime_error("hej")); }, // ex in post
|
|
[] { BOOST_FAIL("should not reach"); }, // should not reach waiter "then"
|
|
true,
|
|
true
|
|
);
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_no_propagate_exception_in_op) {
|
|
return test_propagation(false, // do not propagate exception to waiter
|
|
[] { return make_exception_future(std::runtime_error("hej")); }, // ex in op
|
|
[] { BOOST_FAIL("should not reach"); }, // should not reach post
|
|
[] {}, // should reach waiter "then"
|
|
true,
|
|
false
|
|
);
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_no_propagate_exception_in_post) {
|
|
return test_propagation(false, // do not propagate exception to waiter
|
|
[] {}, // ok func
|
|
[] { return make_exception_future(std::runtime_error("hej")); }, // ex in post
|
|
[] {}, // should reach waiter "then"
|
|
true,
|
|
false
|
|
);
|
|
}
|