aa1270a00c
assert() is traditionally disabled in release builds, but not in
scylladb. This hasn't caused problems so far, but the latest abseil
release includes a commit [1] that causes a 1000 insn/op regression when
NDEBUG is not defined.
Clearly, we must move towards a build system where NDEBUG is defined in
release builds. But we can't just define it blindly without vetting
all the assert() calls, as some were written with the expectation that
they are enabled in release mode.
To solve the conundrum, change all assert() calls to a new SCYLLA_ASSERT()
macro in utils/assert.hh. This macro is always defined and is not conditional
on NDEBUG, so we can later (after vetting Seastar) enable NDEBUG in release
mode.
[1] 66ef711d68
Closes scylladb/scylladb#20006
115 lines
3.2 KiB
C++
115 lines
3.2 KiB
C++
/*
|
|
* Copyright (C) 2018-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include "utils/assert.hh"
|
|
#include "utils/limiting_data_source.hh"
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
#include "test/lib/scylla_test_case.hh"
|
|
#include <seastar/testing/thread_test_case.hh>
|
|
#include <seastar/core/iostream.hh>
|
|
#include <seastar/core/temporary_buffer.hh>
|
|
#include <seastar/core/thread.hh>
|
|
#include <cstdint>
|
|
|
|
using namespace seastar;
|
|
|
|
namespace {
|
|
|
|
class test_data_source_impl : public data_source_impl {
|
|
char _cur = 0;
|
|
void advance(uint64_t n) {
|
|
_cur = (_cur + n) % (std::numeric_limits<char>::max() + 1);
|
|
}
|
|
public:
|
|
static const unsigned chunk_limit = 10;
|
|
test_data_source_impl() { }
|
|
|
|
test_data_source_impl(test_data_source_impl&&) noexcept = default;
|
|
test_data_source_impl& operator=(test_data_source_impl&&) noexcept = default;
|
|
|
|
virtual future<temporary_buffer<char>> get() override {
|
|
temporary_buffer<char> res(chunk_limit);
|
|
for (unsigned i = 0; i < chunk_limit; ++i) {
|
|
res.get_write()[i] = _cur;
|
|
advance(1);
|
|
}
|
|
return make_ready_future<temporary_buffer<char>>(std::move(res));
|
|
}
|
|
virtual future<temporary_buffer<char>> skip(uint64_t n) override {
|
|
advance(n);
|
|
return get();
|
|
}
|
|
};
|
|
|
|
data_source create_test_data_source() {
|
|
return data_source{std::make_unique<test_data_source_impl>()};
|
|
}
|
|
|
|
void test_get(unsigned limit) {
|
|
auto src = create_test_data_source();
|
|
auto tested = make_limiting_data_source(std::move(src), [limit] { return limit; });
|
|
char expected = 0;
|
|
auto test_get = [&] {
|
|
auto buf = tested.get().get();
|
|
BOOST_REQUIRE(buf.size() <= limit);
|
|
for (unsigned i = 0; i < buf.size(); ++i) {
|
|
BOOST_REQUIRE_EQUAL(expected++, buf[i]);
|
|
}
|
|
};
|
|
test_get();
|
|
test_get();
|
|
test_get();
|
|
}
|
|
|
|
data_source prepare_test_skip() {
|
|
auto src = create_test_data_source();
|
|
auto tested = make_limiting_data_source(std::move(src), [] { return 1; });
|
|
auto buf = tested.get().get();
|
|
BOOST_REQUIRE_EQUAL(1, buf.size());
|
|
BOOST_REQUIRE_EQUAL(0, buf[0]);
|
|
// At this point we have 9 chars buffered in limiting_data_source_impl
|
|
return tested;
|
|
}
|
|
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_get_smaller_than_limit) {
|
|
SCYLLA_ASSERT(test_data_source_impl::chunk_limit > 1);
|
|
test_get(test_data_source_impl::chunk_limit - 1);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_get_equal_to_limit) {
|
|
test_get(test_data_source_impl::chunk_limit);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_get_smaller_bigger_than_limit) {
|
|
test_get(test_data_source_impl::chunk_limit + 1);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_skip_smaller_than_buffered_data) {
|
|
auto tested = prepare_test_skip();
|
|
auto buf = tested.skip(8).get();
|
|
BOOST_REQUIRE_EQUAL(1, buf.size());
|
|
BOOST_REQUIRE_EQUAL(9, buf[0]);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_skip_equal_to_buffered_data) {
|
|
auto tested = prepare_test_skip();
|
|
auto buf = tested.skip(9).get();
|
|
BOOST_REQUIRE_EQUAL(1, buf.size());
|
|
BOOST_REQUIRE_EQUAL(10, buf[0]);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_skip_bigger_than_buffered_data) {
|
|
auto tested = prepare_test_skip();
|
|
auto buf = tested.skip(10).get();
|
|
BOOST_REQUIRE_EQUAL(1, buf.size());
|
|
BOOST_REQUIRE_EQUAL(11, buf[0]);
|
|
}
|