eb46f1bd17
Replacing `minimum_keyspace_rf` config option with 4 config options:
`{minimum,maximum}_replication_factor_{warn,fail}_threshold`, which
allow us to impose soft limits (issue a warning) and hard limits (not
execute CQL) on RF when creating/altering a keyspace.
The reason to rather replace than extend `minimum_keyspace_rf` config
option is to be aligned with Cassandra, which did the same, and has the
same parameters' names.
Only min soft limit is enabled by default and it is set to 3, which means
that we'll generate a CQL warning whenever RF is set to either 1 or 2.
RF's value of 0 is always allowed and means that there will not be any
replicas on a given DC. This was agreed with PM.
Because we don't allow to change guardrails' values when scylla is
running (per PM), there're no tests provided with this PR, and dtests will be
provided separately.
Exceeding guardrails' thresholds will be tracked by metrics.
Resolves #8619
Refs #8892 (the RF part, not the replication-strategy part)
Closes #14262
88 lines
2.5 KiB
C++
88 lines
2.5 KiB
C++
/*
|
|
* Copyright (C) 2015-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: (AGPL-3.0-or-later and Apache-2.0)
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "cql3/statements/schema_altering_statement.hh"
|
|
#include "transport/event.hh"
|
|
|
|
#include <seastar/core/shared_ptr.hh>
|
|
|
|
namespace locator {
|
|
|
|
class token_metadata;
|
|
|
|
};
|
|
|
|
namespace data_dictionary {
|
|
class keyspace_metadata;
|
|
}
|
|
|
|
namespace cql3 {
|
|
|
|
class query_processor;
|
|
|
|
namespace statements {
|
|
|
|
class ks_prop_defs;
|
|
|
|
/** A <code>CREATE KEYSPACE</code> statement parsed from a CQL query. */
|
|
class create_keyspace_statement : public schema_altering_statement {
|
|
private:
|
|
sstring _name;
|
|
shared_ptr<ks_prop_defs> _attrs;
|
|
bool _if_not_exists;
|
|
|
|
public:
|
|
/**
|
|
* Creates a new <code>CreateKeyspaceStatement</code> instance for a given
|
|
* keyspace name and keyword arguments.
|
|
*
|
|
* @param name the name of the keyspace to create
|
|
* @param attrs map of the raw keyword arguments that followed the <code>WITH</code> keyword.
|
|
*/
|
|
create_keyspace_statement(const sstring& name, shared_ptr<ks_prop_defs> attrs, bool if_not_exists);
|
|
|
|
virtual const sstring& keyspace() const override;
|
|
|
|
virtual future<> check_access(query_processor& qp, const service::client_state& state) const override;
|
|
|
|
/**
|
|
* The <code>CqlParser</code> only goes as far as extracting the keyword arguments
|
|
* from these statements, so this method is responsible for processing and
|
|
* validating.
|
|
*
|
|
* @throws InvalidRequestException if arguments are missing or unacceptable
|
|
*/
|
|
virtual void validate(query_processor&, const service::client_state& state) const override;
|
|
|
|
|
|
future<std::tuple<::shared_ptr<cql_transport::event::schema_change>, std::vector<mutation>, cql3::cql_warnings_vec>> prepare_schema_mutations(query_processor& qp, api::timestamp_type) const override;
|
|
|
|
virtual std::unique_ptr<prepared_statement> prepare(data_dictionary::database db, cql_stats& stats) override;
|
|
|
|
virtual future<> grant_permissions_to_creator(const service::client_state&) const override;
|
|
|
|
virtual future<::shared_ptr<messages::result_message>>
|
|
execute(query_processor& qp, service::query_state& state, const query_options& options, std::optional<service::group0_guard> guard) const override;
|
|
|
|
lw_shared_ptr<data_dictionary::keyspace_metadata> get_keyspace_metadata(const locator::token_metadata& tm);
|
|
};
|
|
|
|
std::optional<sstring> check_restricted_replication_strategy(
|
|
query_processor& qp,
|
|
const sstring& keyspace,
|
|
const ks_prop_defs& attrs,
|
|
cql_stats& stats);
|
|
|
|
}
|
|
|
|
}
|