Pavel Emelyanov f621afa3ec database: Copy storage options too when updating keyspace metadata ...

When altering a keyspace several keyspace_metadata objects are created
along the way. The last one, that is then kept on the keyspace_metadata
object, forgets to get its copy of storage options thus transparently
converting to LOCAL type.

The bug surfaces itself when altering replication strategy class for
S3-backed storage -- the 2nd attempt fails, because after the 1st one
the keyspace_metadata gets LOCAL storage options and changing storage
options is not allowed.

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>

Closes scylladb/scylladb#16524

2023-12-25 13:31:15 +02:00

..

CMakeLists.txt

build: cmake: add check-header target

2023-11-13 10:27:06 +02:00

compaction_group.hh

replica: Kill unused calculate_disk_space_used_for()

2023-12-18 10:22:19 -03:00

data_dictionary_impl.hh

replica: iterate safely over tables related maps

2023-07-25 17:13:04 +02:00

database_fwd.hh

Introduce schema/ module

2023-02-15 11:01:50 +02:00

database.cc

database: Copy storage options too when updating keyspace metadata

2023-12-25 13:31:15 +02:00

database.hh

replica: Make the storage snapshot survive concurrent compactions

2023-12-21 12:50:28 +02:00

dirty_memory_manager.cc

database: Remove compaction_manager.hh inclusion into database.hh

2023-04-23 16:27:11 +03:00

dirty_memory_manager.hh

Typos: fix typos in comments

2023-12-02 22:37:22 +02:00

distributed_loader.cc

Typos: fix typos in comments

2023-12-02 22:37:22 +02:00

distributed_loader.hh

system_keyspace: move load_truncation_times into distributed_loader::populate_keyspace

2023-10-05 15:19:52 +04:00

exceptions.cc

replica: add abort_requested_exception to exception_variant

2023-07-13 16:57:10 +02:00

exceptions.hh

replica: add abort_requested_exception to exception_variant

2023-07-13 16:57:10 +02:00

global_table_ptr.hh

table: Add global_table_ptr::as_sharded_parameter()

2023-10-06 15:53:57 +03:00

memtable-sstable.hh

tests: Shorten the write_memtable_to_sstable_for_test()

2023-11-20 14:27:57 +03:00

memtable.cc

replica: memtable: don't forget memtable memory allocation statistics

2023-10-18 17:43:33 +02:00

memtable.hh

dht: refactor i_partitioner.hh

2023-11-05 20:01:27 +02:00

mutation_dump.cc

replica/mutation_dump: detect end-of-page in range-scans

2023-09-22 02:53:15 -04:00

mutation_dump.hh

replica: add mutation_dump

2023-07-19 01:28:28 -04:00

query_state.hh

replica: extract query_state into own header

2023-07-19 01:28:28 -04:00

query.hh

replica: add query.hh

2023-05-12 07:26:18 -04:00

table.cc

replica: Make the storage snapshot survive concurrent compactions

2023-12-21 12:50:28 +02:00

tablet_mutation_builder.hh

tablets: Add per-tablet session id field to tablet metadata

2023-12-06 18:36:17 +01:00

tablets.cc

tablets: Fail gracefully when migrating tablet has no pending replica

2023-12-06 18:36:17 +01:00

tablets.hh

transport: add function to add tablet info to the result_message

2023-11-21 15:15:20 +01:00