mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-23 01:50:35 +00:00
We were missing calls to underlying_type in a few locations and so the insert would think the given literal was invalid and the select would refuse to fetch a UDT field. Fixes #4672 Signed-off-by: Rafael Ávila de Espíndola <espindola@scylladb.com> Message-Id: <20190708200516.59841-1-espindola@scylladb.com>
168 lines
6.6 KiB
C++
168 lines
6.6 KiB
C++
/*
|
|
* Copyright (C) 2015 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <seastar/core/shared_ptr.hh>
|
|
|
|
#include "tuples.hh"
|
|
#include "types/list.hh"
|
|
|
|
namespace cql3 {
|
|
|
|
shared_ptr<column_specification>
|
|
tuples::component_spec_of(shared_ptr<column_specification> column, size_t component) {
|
|
return ::make_shared<column_specification>(
|
|
column->ks_name,
|
|
column->cf_name,
|
|
::make_shared<column_identifier>(format("{}[{:d}]", column->name, component), true),
|
|
static_pointer_cast<const tuple_type_impl>(column->type->underlying_type())->type(component));
|
|
}
|
|
|
|
shared_ptr<term>
|
|
tuples::literal::prepare(database& db, const sstring& keyspace, shared_ptr<column_specification> receiver) {
|
|
validate_assignable_to(db, keyspace, receiver);
|
|
std::vector<shared_ptr<term>> values;
|
|
bool all_terminal = true;
|
|
for (size_t i = 0; i < _elements.size(); ++i) {
|
|
auto&& value = _elements[i]->prepare(db, keyspace, component_spec_of(receiver, i));
|
|
if (dynamic_pointer_cast<non_terminal>(value)) {
|
|
all_terminal = false;
|
|
}
|
|
values.push_back(std::move(value));
|
|
}
|
|
delayed_value value(static_pointer_cast<const tuple_type_impl>(receiver->type), values);
|
|
if (all_terminal) {
|
|
return value.bind(query_options::DEFAULT);
|
|
} else {
|
|
return make_shared(std::move(value));
|
|
}
|
|
}
|
|
|
|
shared_ptr<term>
|
|
tuples::literal::prepare(database& db, const sstring& keyspace, const std::vector<shared_ptr<column_specification>>& receivers) {
|
|
if (_elements.size() != receivers.size()) {
|
|
throw exceptions::invalid_request_exception(format("Expected {:d} elements in value tuple, but got {:d}: {}", receivers.size(), _elements.size(), *this));
|
|
}
|
|
|
|
std::vector<shared_ptr<term>> values;
|
|
std::vector<data_type> types;
|
|
bool all_terminal = true;
|
|
for (size_t i = 0; i < _elements.size(); ++i) {
|
|
auto&& t = _elements[i]->prepare(db, keyspace, receivers[i]);
|
|
if (dynamic_pointer_cast<non_terminal>(t)) {
|
|
all_terminal = false;
|
|
}
|
|
values.push_back(t);
|
|
types.push_back(receivers[i]->type);
|
|
}
|
|
delayed_value value(tuple_type_impl::get_instance(std::move(types)), std::move(values));
|
|
if (all_terminal) {
|
|
return value.bind(query_options::DEFAULT);
|
|
} else {
|
|
return make_shared(std::move(value));
|
|
}
|
|
}
|
|
|
|
tuples::in_value
|
|
tuples::in_value::from_serialized(const fragmented_temporary_buffer::view& value_view, list_type type, const query_options& options) {
|
|
try {
|
|
// Collections have this small hack that validate cannot be called on a serialized object,
|
|
// but the deserialization does the validation (so we're fine).
|
|
return with_linearized(value_view, [&] (bytes_view value) {
|
|
auto l = value_cast<list_type_impl::native_type>(type->deserialize(value, options.get_cql_serialization_format()));
|
|
auto ttype = dynamic_pointer_cast<const tuple_type_impl>(type->get_elements_type());
|
|
assert(ttype);
|
|
|
|
std::vector<std::vector<bytes_opt>> elements;
|
|
elements.reserve(l.size());
|
|
for (auto&& element : l) {
|
|
auto tuple_buff = ttype->decompose(element);
|
|
auto tuple = ttype->split(tuple_buff);
|
|
std::vector<bytes_opt> elems;
|
|
elems.reserve(tuple.size());
|
|
for (auto&& e : tuple) {
|
|
elems.emplace_back(to_bytes_opt(e));
|
|
}
|
|
elements.emplace_back(std::move(elems));
|
|
}
|
|
return tuples::in_value(elements);
|
|
});
|
|
} catch (marshal_exception& e) {
|
|
throw exceptions::invalid_request_exception(e.what());
|
|
}
|
|
}
|
|
|
|
::shared_ptr<column_specification>
|
|
tuples::in_raw::make_in_receiver(const std::vector<shared_ptr<column_specification>>& receivers) {
|
|
std::vector<data_type> types;
|
|
types.reserve(receivers.size());
|
|
sstring in_name = "in(";
|
|
for (auto&& receiver : receivers) {
|
|
in_name += receiver->name->text();
|
|
if (receiver != receivers.back()) {
|
|
in_name += ",";
|
|
}
|
|
|
|
if (receiver->type->is_collection() && receiver->type->is_multi_cell()) {
|
|
throw exceptions::invalid_request_exception("Non-frozen collection columns do not support IN relations");
|
|
}
|
|
|
|
types.emplace_back(receiver->type);
|
|
}
|
|
in_name += ")";
|
|
|
|
auto identifier = make_shared<column_identifier>(in_name, true);
|
|
auto type = tuple_type_impl::get_instance(types);
|
|
return make_shared<column_specification>(receivers.front()->ks_name, receivers.front()->cf_name, identifier, list_type_impl::get_instance(type, false));
|
|
}
|
|
|
|
tuples::in_marker::in_marker(int32_t bind_index, ::shared_ptr<column_specification> receiver)
|
|
: abstract_marker(bind_index, std::move(receiver))
|
|
{
|
|
assert(dynamic_pointer_cast<const list_type_impl>(_receiver->type));
|
|
}
|
|
|
|
shared_ptr<terminal> tuples::in_marker::bind(const query_options& options) {
|
|
const auto& value = options.get_value_at(_bind_index);
|
|
if (value.is_null()) {
|
|
return nullptr;
|
|
} else if (value.is_unset_value()) {
|
|
throw exceptions::invalid_request_exception(format("Invalid unset value for tuple {}", _receiver->name->text()));
|
|
} else {
|
|
auto as_list_type = static_pointer_cast<const list_type_impl>(_receiver->type);
|
|
auto as_tuple_type = static_pointer_cast<const tuple_type_impl>(as_list_type->get_elements_type());
|
|
try {
|
|
with_linearized(*value, [&] (bytes_view v) {
|
|
as_list_type->validate(v, options.get_cql_serialization_format());
|
|
auto l = value_cast<list_type_impl::native_type>(as_list_type->deserialize(v, options.get_cql_serialization_format()));
|
|
|
|
for (auto&& element : l) {
|
|
as_tuple_type->validate(as_tuple_type->decompose(element), options.get_cql_serialization_format());
|
|
}
|
|
});
|
|
} catch (marshal_exception& e) {
|
|
throw exceptions::invalid_request_exception(e.what());
|
|
}
|
|
return make_shared(tuples::in_value::from_serialized(*value, as_list_type, options));
|
|
}
|
|
}
|
|
|
|
}
|