Files
scylladb/test/boost/serialized_action_test.cc
Benny Halevy b3f46e9cbf test: serialized_action_test: add test_serialized_action_exception
Tests that the exceptional future returned by the serialized action
is propagated to trigger, reproducing #7352.

The test fails without the previoud patch:
"serialized_action: trigger: include also semaphore status to promise"

Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
2020-10-14 16:45:21 +03:00

144 lines
4.6 KiB
C++

/*
* Copyright (C) 2017 ScyllaDB
*/
/*
* This file is part of Scylla.
*
* Scylla is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Scylla is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
*/
#include <boost/test/unit_test.hpp>
#include <seastar/core/thread.hh>
#include <seastar/core/semaphore.hh>
#include "utils/serialized_action.hh"
#include <seastar/testing/test_case.hh>
#include <seastar/testing/thread_test_case.hh>
#include "utils/phased_barrier.hh"
SEASTAR_TEST_CASE(test_serialized_action_triggering) {
return seastar::async([] {
int current = 0;
std::vector<int> history;
promise<> p;
seastar::semaphore sem{0};
serialized_action act([&] {
sem.signal(1);
auto val = current;
return p.get_future().then([&, val] {
history.push_back(val);
});
});
auto release = [&] {
std::exchange(p, promise<>()).set_value();
};
auto t1 = act.trigger();
sem.wait().get(); // wait for t1 action to block
current = 1;
auto t2 = act.trigger();
auto t3 = act.trigger();
current = 2;
release();
t1.get();
BOOST_REQUIRE(history.size() == 1);
BOOST_REQUIRE(history.back() == 0);
BOOST_REQUIRE(!t2.available());
BOOST_REQUIRE(!t3.available());
sem.wait().get(); // wait for t2 action to block
current = 3;
auto t4 = act.trigger();
release();
t2.get();
t3.get();
BOOST_REQUIRE(history.size() == 2);
BOOST_REQUIRE(history.back() == 2);
BOOST_REQUIRE(!t4.available());
sem.wait().get(); // wait for t4 action to block
current = 4;
release();
t4.get();
BOOST_REQUIRE(history.size() == 3);
BOOST_REQUIRE(history.back() == 3);
current = 5;
auto t5 = act.trigger();
sem.wait().get(); // wait for t5 action to block
release();
t5.get();
BOOST_REQUIRE(history.size() == 4);
BOOST_REQUIRE(history.back() == 5);
});
}
SEASTAR_THREAD_TEST_CASE(test_serialized_action_exception) {
class expected_exception : public std::exception {
public:
virtual const char* what() const noexcept override {
return "expected_exception";
}
};
serialized_action simple_action([&] {
return make_exception_future<>(expected_exception());
});
// test that the exception returned by the serialized action
// is propageted to the caller of trigger().
BOOST_REQUIRE_THROW(simple_action.trigger(false).get(), expected_exception);
BOOST_REQUIRE_THROW(simple_action.trigger(true).get(), expected_exception);
int count = 0;
promise<> p;
seastar::semaphore sem{0};
serialized_action triggered_action([&] {
sem.signal(1);
return p.get_future().then([&] {
count++;
return make_exception_future<>(expected_exception());
});
});
auto release = [&] {
std::exchange(p, promise<>()).set_value();
};
// test that the exception returned by the serialized action
// is propageted to pending callers of trigger().
auto t1 = triggered_action.trigger(); // launch the action in the background.
sem.wait().get(); // wait for t1 to block on `p`.
auto t2 = triggered_action.trigger(); // trigger the action again.
auto t3 = triggered_action.trigger(); // trigger the action again. t3 and t2 should share the same future.
release(); // signal t1 to proceed (and return the exception).
BOOST_REQUIRE_THROW(t1.get(), expected_exception);
BOOST_REQUIRE_EQUAL(count, 1);
sem.wait().get(); // wait for t2 to block on `p`.
release(); // signal t2 to proceed (and return the exception).
BOOST_REQUIRE_THROW(t2.get(), expected_exception);
BOOST_REQUIRE_THROW(t3.get(), expected_exception);
BOOST_REQUIRE_EQUAL(count, 2); // verify that `triggered_action` was called only once for t2 and t3.
}