Files
scylladb/tombstone.hh
Avi Kivity 6f394e8e90 tombstone: use comparison operator instead of ad-hoc compare() function and with_relational_operators
The comparison operator (<=>) default implementation happens to exactly
match tombstone::compare(), so use the compiler-generated defaults. Also
default operator== and operator!= (these are not brought in by operator<=>).
These become slightly faster as they perform just an equality comparison,
not three-way compare.

shadowable_tombstone and row_tombstone depend on tombstone::compare(),
so convert them too in a similar way.

with_relational_operations.hh becomes unused, so delete it.

Tests: unit (dev)
Message-Id: <20200602055626.2874801-1-avi@scylladb.com>
2020-06-02 09:28:52 +03:00

101 lines
2.7 KiB
C++

/*
* Copyright (C) 2015 ScyllaDB
*/
/*
* This file is part of Scylla.
*
* Scylla is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Scylla is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
*/
#pragma once
#include <functional>
#include <compare>
#include "timestamp.hh"
#include "gc_clock.hh"
#include "hashing.hh"
/**
* Represents deletion operation. Can be commuted with other tombstones via apply() method.
* Can be empty.
*/
struct tombstone final {
api::timestamp_type timestamp;
gc_clock::time_point deletion_time;
tombstone(api::timestamp_type timestamp, gc_clock::time_point deletion_time)
: timestamp(timestamp)
, deletion_time(deletion_time)
{ }
tombstone()
: tombstone(api::missing_timestamp, {})
{ }
std::strong_ordering operator<=>(const tombstone& t) const = default;
bool operator==(const tombstone&) const = default;
bool operator!=(const tombstone&) const = default;
explicit operator bool() const {
return timestamp != api::missing_timestamp;
}
void apply(const tombstone& t) noexcept {
if (*this < t) {
*this = t;
}
}
// See reversibly_mergeable.hh
void apply_reversibly(tombstone& t) noexcept {
std::swap(*this, t);
apply(t);
}
// See reversibly_mergeable.hh
void revert(tombstone& t) noexcept {
std::swap(*this, t);
}
tombstone operator+(const tombstone& t) {
auto result = *this;
result.apply(t);
return result;
}
friend std::ostream& operator<<(std::ostream& out, const tombstone& t) {
if (t) {
return out << "{tombstone: timestamp=" << t.timestamp << ", deletion_time=" << t.deletion_time.time_since_epoch().count() << "}";
} else {
return out << "{tombstone: none}";
}
}
};
template<>
struct appending_hash<tombstone> {
template<typename Hasher>
void operator()(Hasher& h, const tombstone& t) const {
feed_hash(h, t.timestamp);
feed_hash(h, t.deletion_time);
}
};
// Determines whether tombstone may be GC-ed.
using can_gc_fn = std::function<bool(tombstone)>;
extern can_gc_fn always_gc;