Files
scylladb/mutation_reader.cc
Avi Kivity 8547f34d60 mutation_reader: make restricting_mutation_reader even more restricting
While limiting the number of concurrently executing sstable readers reduces
our memory load, the queued readers, although consuming a small amount of
memory, can still grow without bounds.

To limit the damage, add two limits on the queue:
 - a timeout, which is equal to the read timeout
 - a queue length limit, which is equal to 2% of the shard memory divided
   by an estimate of the queued request size (1kb)

Together, these limits bound the amount of memory needed by queued disk
requests in case the disk can't keep up.
Message-Id: <1467206055-30769-1-git-send-email-avi@scylladb.com>

(cherry picked from commit 9ac730dcc9)
2016-06-29 17:29:00 +03:00

260 lines
8.3 KiB
C++

/*
* Copyright (C) 2015 ScyllaDB
*/
/*
* This file is part of Scylla.
*
* Scylla is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Scylla is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
*/
#include <boost/range/algorithm/heap_algorithm.hpp>
#include <boost/range/algorithm/reverse.hpp>
#include "mutation_reader.hh"
#include "core/future-util.hh"
#include "utils/move.hh"
namespace stdx = std::experimental;
// Combines multiple mutation_readers into one.
class combined_reader final : public mutation_reader::impl {
std::vector<mutation_reader> _readers;
struct mutation_and_reader {
mutation m;
mutation_reader* read;
};
std::vector<mutation_and_reader> _ptables;
// comparison function for std::make_heap()/std::push_heap()
static bool heap_compare(const mutation_and_reader& a, const mutation_and_reader& b) {
auto&& s = a.m.schema();
// order of comparison is inverted, because heaps produce greatest value first
return b.m.decorated_key().less_compare(*s, a.m.decorated_key());
}
mutation_opt _current;
bool _inited = false;
private:
// Produces next mutation or disengaged optional if there are no more.
//
// Entry conditions:
// - either _ptables is empty or_ptables.back() is the next item to be consumed.
// - the _ptables heap is in invalid state (if not empty), waiting for pop_back or push_heap.
future<mutation_opt> next() {
if (_ptables.empty()) {
return make_ready_future<mutation_opt>(move_and_disengage(_current));
};
auto& candidate = _ptables.back();
mutation& m = candidate.m;
if (_current && !_current->decorated_key().equal(*m.schema(), m.decorated_key())) {
// key has changed, so emit accumulated mutation
return make_ready_future<mutation_opt>(move_and_disengage(_current));
}
apply(_current, std::move(m));
return (*candidate.read)().then([this] (mutation_opt&& more) {
// Restore heap to valid state
if (!more) {
_ptables.pop_back();
} else {
_ptables.back().m = std::move(*more);
boost::range::push_heap(_ptables, &heap_compare);
}
boost::range::pop_heap(_ptables, &heap_compare);
return next();
});
}
public:
combined_reader(std::vector<mutation_reader> readers)
: _readers(std::move(readers))
{ }
virtual future<mutation_opt> operator()() override {
if (!_inited) {
return parallel_for_each(_readers, [this] (mutation_reader& reader) {
return reader().then([this, &reader](mutation_opt&& m) {
if (m) {
_ptables.push_back({std::move(*m), &reader});
}
});
}).then([this] {
boost::range::make_heap(_ptables, &heap_compare);
boost::range::pop_heap(_ptables, &heap_compare);
_inited = true;
return next();
});
}
return next();
}
};
mutation_reader
make_combined_reader(std::vector<mutation_reader> readers) {
return make_mutation_reader<combined_reader>(std::move(readers));
}
class joining_reader final : public mutation_reader::impl {
std::vector<mutation_reader> _readers;
std::vector<mutation_reader>::iterator _current;
public:
joining_reader(std::vector<mutation_reader> readers)
: _readers(std::move(readers))
, _current(_readers.begin()) {
}
joining_reader(joining_reader&&) = default;
virtual future<mutation_opt> operator()() override {
if (_current == _readers.end()) {
return make_ready_future<mutation_opt>(stdx::nullopt);
}
return (*_current)().then([this] (mutation_opt m) {
if (!m) {
++_current;
return operator()();
} else {
return make_ready_future<mutation_opt>(std::move(m));
}
});
}
};
mutation_reader
make_combined_reader(mutation_reader&& a, mutation_reader&& b) {
std::vector<mutation_reader> v;
v.reserve(2);
v.push_back(std::move(a));
v.push_back(std::move(b));
return make_combined_reader(std::move(v));
}
mutation_reader
make_joining_reader(std::vector<mutation_reader> readers) {
return make_mutation_reader<joining_reader>(std::move(readers));
}
class lazy_reader final : public mutation_reader::impl {
std::function<mutation_reader ()> _make_reader;
stdx::optional<mutation_reader> _reader;
public:
lazy_reader(std::function<mutation_reader ()> make_reader)
: _make_reader(std::move(make_reader)) {
}
virtual future<mutation_opt> operator()() override {
if (!_reader) {
_reader = _make_reader();
}
return (*_reader)();
}
};
mutation_reader
make_lazy_reader(std::function<mutation_reader ()> make_reader) {
return make_mutation_reader<lazy_reader>(std::move(make_reader));
}
class reader_returning final : public mutation_reader::impl {
mutation _m;
bool _done = false;
public:
reader_returning(mutation m) : _m(std::move(m)) {
}
virtual future<mutation_opt> operator()() override {
if (_done) {
return make_ready_future<mutation_opt>();
} else {
_done = true;
return make_ready_future<mutation_opt>(std::move(_m));
}
}
};
mutation_reader make_reader_returning(mutation m) {
return make_mutation_reader<reader_returning>(std::move(m));
}
class reader_returning_many final : public mutation_reader::impl {
std::vector<mutation> _m;
bool _done = false;
public:
reader_returning_many(std::vector<mutation> m) : _m(std::move(m)) {
boost::range::reverse(_m);
}
virtual future<mutation_opt> operator()() override {
if (_m.empty()) {
return make_ready_future<mutation_opt>();
}
auto m = std::move(_m.back());
_m.pop_back();
return make_ready_future<mutation_opt>(std::move(m));
}
};
mutation_reader make_reader_returning_many(std::vector<mutation> mutations) {
return make_mutation_reader<reader_returning_many>(std::move(mutations));
}
class empty_reader final : public mutation_reader::impl {
public:
virtual future<mutation_opt> operator()() override {
return make_ready_future<mutation_opt>();
}
};
mutation_reader make_empty_reader() {
return make_mutation_reader<empty_reader>();
}
class restricting_mutation_reader : public mutation_reader::impl {
const restricted_mutation_reader_config& _config;
unsigned _weight = 0;
bool _waited = false;
mutation_reader _base;
public:
restricting_mutation_reader(const restricted_mutation_reader_config& config, unsigned weight, mutation_reader&& base)
: _config(config), _weight(weight), _base(std::move(base)) {
if (_config.sem->waiters() >= _config.max_queue_length) {
_config.raise_queue_overloaded_exception();
}
}
~restricting_mutation_reader() {
if (_waited) {
_config.sem->signal(_weight);
}
}
future<mutation_opt> operator()() override {
// FIXME: we should defer freeing until the mutation is freed, perhaps,
// rather than just returned
if (_waited) {
return _base();
}
auto waited = _config.timeout.count() != 0
? _config.sem->wait(_config.timeout, _weight)
: _config.sem->wait(_weight);
return waited.then([this] {
_waited = true;
return _base();
});
}
};
mutation_reader
make_restricted_reader(const restricted_mutation_reader_config& config, unsigned weight, mutation_reader&& base) {
return make_mutation_reader<restricting_mutation_reader>(config, weight, std::move(base));
}