mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-26 11:30:36 +00:00
fbb11dac11
modification_statement::process_where_clause() assumes that both
operations and conditions has been added to the statement when it's
called: it uses this information to raise an error in case the statement
restrictions are incompatible with operations or conditions. Currently,
operations are set before this function is called, but not conditions.
This results in "Invalid restrictions on clustering columns since
the {} statement modifies only static columns" error while trying to
execute the following statements:
create table t(k int, c int, s int static, v int, primary key(k, c));
delete s from t where k=1 and c=1 if v=1;
update t set s=1 where k=1 and c=1 if v=1;
Fix this by always initializing conditions before processing WHERE
clause.
102 lines
3.6 KiB
C++
102 lines
3.6 KiB
C++
/*
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2015 ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "cql3/restrictions/restriction.hh"
|
|
#include "cql3/statements/raw/cf_statement.hh"
|
|
#include "cql3/column_identifier.hh"
|
|
#include "cql3/update_parameters.hh"
|
|
#include "cql3/column_condition.hh"
|
|
#include "cql3/cql_statement.hh"
|
|
#include "cql3/attributes.hh"
|
|
#include "cql3/operation.hh"
|
|
#include "cql3/relation.hh"
|
|
|
|
#include <seastar/core/shared_ptr.hh>
|
|
#include <seastar/core/future-util.hh>
|
|
|
|
#include "unimplemented.hh"
|
|
#include "validation.hh"
|
|
#include "service/storage_proxy.hh"
|
|
|
|
#include <memory>
|
|
|
|
namespace cql3 {
|
|
|
|
namespace statements {
|
|
|
|
class modification_statement;
|
|
|
|
namespace raw {
|
|
|
|
class modification_statement : public cf_statement {
|
|
public:
|
|
using conditions_vector = std::vector<std::pair<::shared_ptr<column_identifier::raw>, ::shared_ptr<column_condition::raw>>>;
|
|
protected:
|
|
const ::shared_ptr<attributes::raw> _attrs;
|
|
const std::vector<std::pair<::shared_ptr<column_identifier::raw>, ::shared_ptr<column_condition::raw>>> _conditions;
|
|
private:
|
|
const bool _if_not_exists;
|
|
const bool _if_exists;
|
|
protected:
|
|
modification_statement(::shared_ptr<cf_name> name, ::shared_ptr<attributes::raw> attrs, conditions_vector conditions, bool if_not_exists, bool if_exists);
|
|
|
|
public:
|
|
virtual std::unique_ptr<prepared> prepare(database& db, cql_stats& stats) override;
|
|
::shared_ptr<cql3::statements::modification_statement> prepare(database& db, ::shared_ptr<variable_specifications> bound_names, cql_stats& stats);
|
|
protected:
|
|
virtual ::shared_ptr<cql3::statements::modification_statement> prepare_internal(database& db, schema_ptr schema,
|
|
::shared_ptr<variable_specifications> bound_names, std::unique_ptr<attributes> attrs, cql_stats& stats) = 0;
|
|
|
|
// Helper function used by child classes to prepare conditions for a prepared statement.
|
|
// Must be called before processing WHERE clause, because to perform sanity checks there
|
|
// we need to know what kinds of conditions (static, regular) the statement has.
|
|
void prepare_conditions(database& db, schema_ptr schema, ::shared_ptr<variable_specifications> bound_names,
|
|
cql3::statements::modification_statement& stmt);
|
|
};
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|