mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-30 11:36:54 +00:00
aad5eeab51
If Alternator is requested to be enabled on a specific port but the port is already taken, the boot fails as expected - but the error log is confusing; It currently looks something like this: WARN 2019-12-24 11:22:57,303 [shard 0] alternator-server - Failed to set up Alternator HTTP server on 0.0.0.0 port 8000, TLS port 8043: std::system_error (error system:98, posix_listen failed for address 0.0.0.0:8000: Address already in use) ... (many more messages about the server shutting down) INFO 2019-12-24 11:22:58,008 [shard 0] init - Startup failed: std::system_error (error system:98, posix_listen failed for address 0.0.0.0:8000: Address already in use) There are two problems here. First, the "WARN" should really be an "ERROR", because it causes the server to be shut down and the user must see this error. Second, the final line in the log, something the user is likely to see first, contains only the ultimate cause for the exception (an address already in use) but not the information what this address was needed for. This patch solves both issues, and the log now looks like: ERROR 2019-12-24 14:00:54,496 [shard 0] alternator-server - Failed to set up Alterna tor HTTP server on 0.0.0.0 port 8000, TLS port 8043: std::system_error (error system :98, posix_listen failed for address 0.0.0.0:8000: Address already in use) ... INFO 2019-12-24 14:00:55,056 [shard 0] init - Startup failed: std::_Nested_exception<std::runtime_error> (Failed to set up Alternator HTTP server on 0.0.0.0 port 8000, TLS port 8043): std::system_error (error system:98, posix_listen failed for address 0.0.0.0:8000: Address already in use) Signed-off-by: Nadav Har'El <nyh@scylladb.com> Message-Id: <20191224124127.7093-1-nyh@scylladb.com>