d3ee82ea51
After parallel tablet draining, the validation at the time request starts executing is too late, tablets will be already drained. This trips tests which expect validation failure, but get tablet draining failure instead. Also, in case of decommission, it's a waste to go through draining only to discover that the operation has to be rolled back due to validation. So avoid submitting a request altogether if it's invalid. The validation at request execution start remains, for extra sefety. validate_removing_node() was extracted out of topology_coordinator, so that it can be called by storage_service on non-coordinator. Some tests need adjusting for the fact that after failed removenode the node may still not be marked as excluded, so we need to explicitly exclude it or add to the list of ignored nodes in the next removenode operation.
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cqlpy - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.