Botond Dénes d6a79fefda Merge 'Do not leak S3 file-uploading parts on exceptions' from Pavel Emelyanov ...

File uploading code spawns all parts uploading into background. If this "spawning" fails (not the uploading code itself), any fiber that was spawned before is orphaned. It will eventually stop on its own, by while it's alive it may use(-after-free) the do_upload_file object.

Another issue with not handling spawn exception, is that multipart upload object is not aborted in this case. So it's leaked until garbage collector picks it up, which is not critical, but unpleasant.

Closes scylladb/scylladb#21139

* github.com:scylladb/scylladb:
  s3/client: Restore indentation after previous patch
  s3/client: Catch do_upload_file::upload_part() exceptions

2024-10-23 10:12:29 +03:00

..

aws_error.cc

utils/s3: include used header

2024-10-13 18:32:34 +03:00

aws_error.hh

code: Introduce AWS errors parsing

2024-10-01 09:06:24 +03:00

client.cc

Merge 'Do not leak S3 file-uploading parts on exceptions' from Pavel Emelyanov

2024-10-23 10:12:29 +03:00

client.hh

s3/client: Split upload_sink_base class into two

2024-09-12 18:00:19 +03:00

creds.hh

config: Make object storage config updateable_value_source

2023-11-21 16:47:50 +03:00