mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-01 13:45:53 +00:00
69a68e35dd
Loading schemas of views and indexes was not supported, with either `--schema-file`, or when loading schema from schema sstables. This PR addresses both: * When loading schema from CQL (file), `CREATE MATERIALIZED VIEW` and `CREATE INDEX` statements are now also processed correctly. * When loading schema from schema tables, `system_schema.views` is also processed, when the table has no corresponding entry in `system_schema.tables`. Tests are also added. Fixes: #16492 Closes scylladb/scylladb#16517 * github.com:scylladb/scylladb: test/cql-pytest: test_tools.py: add schema-loading tests for MV/SI test/cql-pytest: test_tools.py: extract some fixture logic to functions test/cql-pytest: test_tools.py: extract common schema-loading facilities into base-class tools/schema_loader: load_schema_from_schema_tables(): add support for MV/SI schemas tools/schema_loader: load_one_schema_from_file(): add support for view/index schemas test/boost/schema_loader_test: add test for mvs and indexes tools/schema_loader: load_schemas(): implement parsing views/indexes from CQL replica/database: extract existing_index_names and get_available_index_name tools/schema_loader: make real_db.tables the only source of truth on existing tables tools/schema_loader: table(): store const keyspace& tools/schema_loader: make database,keyspace,table non-movable cql3/statements/create_index_statement: build_index_schema(): include index metadata in returned value cql3/statements/create_index_statement: make build_index_schema() public cql3/statements/create_index_statement: relax some method's dependence on qp cql3/statements/create_view_statement: make prepare_view() public
76 lines
2.9 KiB
C++
76 lines
2.9 KiB
C++
/*
|
|
* Copyright (C) 2015-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: (AGPL-3.0-or-later and Apache-2.0)
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "schema_altering_statement.hh"
|
|
#include "index_target.hh"
|
|
|
|
#include "schema/schema_fwd.hh"
|
|
|
|
#include <seastar/core/shared_ptr.hh>
|
|
|
|
#include <vector>
|
|
|
|
|
|
namespace cql3 {
|
|
|
|
class query_processor;
|
|
class index_name;
|
|
|
|
namespace statements {
|
|
|
|
class index_prop_defs;
|
|
|
|
/** A <code>CREATE INDEX</code> statement parsed from a CQL query. */
|
|
class create_index_statement : public schema_altering_statement {
|
|
const sstring _index_name;
|
|
const std::vector<::shared_ptr<index_target::raw>> _raw_targets;
|
|
const ::shared_ptr<index_prop_defs> _properties;
|
|
const bool _if_not_exists;
|
|
cql_stats* _cql_stats = nullptr;
|
|
|
|
public:
|
|
create_index_statement(cf_name name, ::shared_ptr<index_name> index_name,
|
|
std::vector<::shared_ptr<index_target::raw>> raw_targets,
|
|
::shared_ptr<index_prop_defs> properties, bool if_not_exists);
|
|
|
|
future<> check_access(query_processor& qp, const service::client_state& state) const override;
|
|
void validate(query_processor&, const service::client_state& state) const override;
|
|
future<std::tuple<::shared_ptr<cql_transport::event::schema_change>, std::vector<mutation>, cql3::cql_warnings_vec>> prepare_schema_mutations(query_processor& qp, api::timestamp_type) const override;
|
|
|
|
|
|
virtual std::unique_ptr<prepared_statement> prepare(data_dictionary::database db, cql_stats& stats) override;
|
|
|
|
struct base_schema_with_new_index {
|
|
schema_ptr schema;
|
|
index_metadata index;
|
|
};
|
|
std::optional<base_schema_with_new_index> build_index_schema(data_dictionary::database db) const;
|
|
private:
|
|
void validate_for_local_index(const schema& schema) const;
|
|
void validate_for_frozen_collection(const index_target& target) const;
|
|
void validate_not_full_index(const index_target& target) const;
|
|
void validate_for_collection(const index_target& target, const column_definition&) const;
|
|
void rewrite_target_for_collection(index_target& target, const column_definition&) const;
|
|
void validate_is_values_index_if_target_column_not_collection(const column_definition* cd,
|
|
const index_target& target) const;
|
|
void validate_target_column_is_map_if_index_involves_keys(bool is_map, const index_target& target) const;
|
|
void validate_targets_for_multi_column_index(std::vector<::shared_ptr<index_target>> targets) const;
|
|
static index_metadata make_index_metadata(const std::vector<::shared_ptr<index_target>>& targets,
|
|
const sstring& name,
|
|
index_metadata_kind kind,
|
|
const index_options_map& options);
|
|
std::vector<::shared_ptr<index_target>> validate_while_executing(data_dictionary::database db) const;
|
|
};
|
|
|
|
}
|
|
}
|