4ffc39d885
Currently we hold group0_guard only during DDL statement's execute() function, but unfortunately some statements access underlying schema state also during check_access() and validate() calls which are called by the query_processor before it calls execute. We need to cover those calls with group0_guard as well and also move retry loop up. This patch does it by introducing new function to cql_statement class take_guard(). Schema altering statements return group0 guard while others do not return any guard. Query processor takes this guard at the beginning of a statement execution and retries if service::group0_concurrent_modification is thrown. The guard is passed to the execute in query_state structure. Fixes: #13942 Message-ID: <ZNsynXayKim2XAFr@scylladb.com>
69 lines
1.9 KiB
C++
69 lines
1.9 KiB
C++
/*
|
|
* Copyright (C) 2014-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: (AGPL-3.0-or-later and Apache-2.0)
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "transport/messages_fwd.hh"
|
|
#include "transport/event.hh"
|
|
|
|
#include "cql3/statements/raw/cf_statement.hh"
|
|
#include "cql3/cql_statement.hh"
|
|
|
|
#include <seastar/core/shared_ptr.hh>
|
|
|
|
#include "service/raft/raft_group0_client.hh"
|
|
|
|
class mutation;
|
|
|
|
namespace cql3 {
|
|
|
|
class query_processor;
|
|
|
|
namespace statements {
|
|
|
|
namespace messages = cql_transport::messages;
|
|
|
|
/**
|
|
* Abstract class for statements that alter the schema.
|
|
*/
|
|
class schema_altering_statement : public raw::cf_statement, public cql_statement_no_metadata {
|
|
private:
|
|
const bool _is_column_family_level;
|
|
|
|
protected:
|
|
explicit schema_altering_statement(timeout_config_selector timeout_selector = &timeout_config::other_timeout);
|
|
|
|
schema_altering_statement(cf_name name, timeout_config_selector timeout_selector = &timeout_config::other_timeout);
|
|
|
|
/**
|
|
* When a new data_dictionary::database object (keyspace, table) is created, the creator needs to be granted all applicable
|
|
* permissions on it.
|
|
*
|
|
* By default, this function does nothing.
|
|
*/
|
|
virtual future<> grant_permissions_to_creator(const service::client_state&) const;
|
|
|
|
virtual bool depends_on(std::string_view ks_name, std::optional<std::string_view> cf_name) const override;
|
|
|
|
virtual uint32_t get_bound_terms() const override;
|
|
|
|
virtual void prepare_keyspace(const service::client_state& state) override;
|
|
|
|
virtual future<::shared_ptr<messages::result_message>>
|
|
execute(query_processor& qp, service::query_state& state, const query_options& options, std::optional<service::group0_guard> guard) const override;
|
|
|
|
public:
|
|
virtual future<std::tuple<::shared_ptr<cql_transport::event::schema_change>, std::vector<mutation>, cql3::cql_warnings_vec>> prepare_schema_mutations(query_processor& qp, api::timestamp_type) const = 0;
|
|
};
|
|
|
|
}
|
|
|
|
}
|