mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-23 10:00:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
db1d3cc342da2abc5da2a32eb6e4d2fba5052d50
scylladb/cql3/statements
History
Calle Wilund d566010412 network_topology_strategy/alter ks: Remove dc:s from options once rf=0 
Fixes #22688

If we set a dc rf to zero, the options map will still retain a dc=0 entry.
If this dc is decommissioned, any further alters of keyspace will fail,
because the union of new/old options will now contained an unknown keyword.

Change alter ks options processing to simply remove any dc with rf=0 on
alter, and treat this as an implicit dc=0 in nw-topo strategy.
This means we change the reallocate_tablets routine to not rely on
the strategy objects dc mapping, but the full replica topology info
for dc:s to consider for reallocation. Since we verify the input
on attribute processing, the amount of rf/tablets moved should still
be legal.

v2:
* Update docs as well.
v3:
* Simplify dc processing
* Reintroduce options empty check, but do early in ks_prop_defs
* Clean up unit test some

Closes scylladb/scylladb#22693

(cherry picked from commit 342df0b1a8)

(Update: workaround python test objects not having dc info)

Closes scylladb/scylladb#22876
2025-04-18 14:09:52 +03:00
..
raw
cql3: do not include unused headers
2024-07-28 17:29:07 +03:00
alter_keyspace_statement.cc
network_topology_strategy/alter ks: Remove dc:s from options once rf=0
2025-04-18 14:09:52 +03:00
alter_keyspace_statement.hh
cql: switch alter keyspace prepare_schema_mutations to use group0_batch
2024-06-18 19:54:55 +02:00
alter_role_statement.hh
cql3: run auth DML writes on shard 0 and with raft guard
2024-03-01 16:25:14 +01:00
alter_service_level_statement.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
alter_service_level_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
alter_table_statement.cc
treewide: use seastar::format() or fmt::format() explicitly
2024-09-11 23:21:40 +03:00
alter_table_statement.hh
cql3/statements: extend ALTER TABLE ... DROP to allow specifying timestamp of column drop
2024-04-25 21:27:40 +02:00
alter_type_statement.cc
treewide: drop thrift support
2024-06-07 06:44:59 +08:00
alter_type_statement.hh
treewide: drop thrift support
2024-06-07 06:44:59 +08:00
alter_view_statement.cc
Merge 'Extend ALTER TABLE ... DROP to allow specifying timestamp of column drop' from Michał Jadwiszczak
2024-04-29 14:05:05 +02:00
alter_view_statement.hh
cql3/statements: pass query_options to prepare_schema_mutations()
2024-04-25 21:27:40 +02:00
attach_service_level_statement.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
attach_service_level_statement.hh
cql3:statements: run service level statements on shard0 with raft guard
2024-03-21 23:14:57 +01:00
authentication_statement.cc
cql3:statements: run service level statements on shard0 with raft guard
2024-03-21 23:14:57 +01:00
authentication_statement.hh
cql3:statements: run service level statements on shard0 with raft guard
2024-03-21 23:14:57 +01:00
authorization_statement.cc
cql3:statements: run service level statements on shard0 with raft guard
2024-03-21 23:14:57 +01:00
authorization_statement.hh
cql3:statements: run service level statements on shard0 with raft guard
2024-03-21 23:14:57 +01:00
batch_statement.cc
treewide: use seastar::format() or fmt::format() explicitly
2024-09-11 23:21:40 +03:00
batch_statement.hh
treewide: drop thrift support
2024-06-07 06:44:59 +08:00
bound.hh
…
cas_request.cc
…
cas_request.hh
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
cf_prop_defs.cc
feature: grandfather PER_TABLE_CACHING
2024-05-18 00:23:30 +03:00
cf_prop_defs.hh
Merge 'treewide: remove {dclocal_,}read_repair_chance options' from Kefu Chai
2024-04-26 10:48:47 +03:00
cf_properties.hh
…
cf_statement.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
create_aggregate_statement.cc
treewide: use seastar::format() or fmt::format() explicitly
2024-09-11 23:21:40 +03:00
create_aggregate_statement.hh
cql3/statements: pass query_options to prepare_schema_mutations()
2024-04-25 21:27:40 +02:00
create_function_statement.cc
lang: Return context as future, not via reference argument
2024-06-12 16:54:46 +03:00
create_function_statement.hh
cql3/statements: pass query_options to prepare_schema_mutations()
2024-04-25 21:27:40 +02:00
create_index_statement.cc
treewide: use seastar::format() or fmt::format() explicitly
2024-09-11 23:21:40 +03:00
create_index_statement.hh
cql3/statements: pass query_options to prepare_schema_mutations()
2024-04-25 21:27:40 +02:00
create_keyspace_statement.cc
cql: adjust warning about tablets
2024-07-09 18:01:37 +02:00
create_keyspace_statement.hh
cql3: extract create ks/table/type/view event code
2024-06-07 10:07:50 +02:00
create_role_statement.hh
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
create_service_level_statement.cc
cql3/statements/create_service_level: forbid creating SL starting with $
2024-08-14 21:25:31 +03:00
create_service_level_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
create_table_statement.cc
treewide: use seastar::format() or fmt::format() explicitly
2024-09-11 23:21:40 +03:00
create_table_statement.hh
cql3: extract create ks/table/type/view event code
2024-06-07 10:07:50 +02:00
create_type_statement.cc
cql3: always return created event in create ks/table/type/view statement
2024-06-07 10:36:40 +02:00
create_type_statement.hh
cql3: extract create ks/table/type/view event code
2024-06-07 10:07:50 +02:00
create_view_statement.cc
treewide: use seastar::format() or fmt::format() explicitly
2024-09-11 23:21:40 +03:00
create_view_statement.hh
cql3: extract create ks/table/type/view event code
2024-06-07 10:07:50 +02:00
delete_statement.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
delete_statement.hh
…
describe_statement.cc
cql3: functions: make functions class non-static
2024-07-04 10:24:57 +02:00
describe_statement.hh
cql3: do not include unused headers
2024-01-16 16:43:17 +02:00
detach_service_level_statement.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
detach_service_level_statement.hh
cql3:statements: run service level statements on shard0 with raft guard
2024-03-21 23:14:57 +01:00
drop_aggregate_statement.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
drop_aggregate_statement.hh
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
drop_function_statement.cc
cql3: functions: make functions class non-static
2024-07-04 10:24:57 +02:00
drop_function_statement.hh
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
drop_index_statement.cc
treewide: drop thrift support
2024-06-07 06:44:59 +08:00
drop_index_statement.hh
cql3/statements: pass query_options to prepare_schema_mutations()
2024-04-25 21:27:40 +02:00
drop_keyspace_statement.cc
treewide: drop thrift support
2024-06-07 06:44:59 +08:00
drop_keyspace_statement.hh
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
drop_role_statement.hh
cql3: run auth DML writes on shard 0 and with raft guard
2024-03-01 16:25:14 +01:00
drop_service_level_statement.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
drop_service_level_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
drop_table_statement.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
drop_table_statement.hh
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
drop_type_statement.cc
cql3: functions: make functions class non-static
2024-07-04 10:24:57 +02:00
drop_type_statement.hh
cql3/statements: pass query_options to prepare_schema_mutations()
2024-04-25 21:27:40 +02:00
drop_view_statement.cc
cql3/statements: pass query_options to prepare_schema_mutations()
2024-04-25 21:27:40 +02:00
drop_view_statement.hh
cql3/statements: pass query_options to prepare_schema_mutations()
2024-04-25 21:27:40 +02:00
function_statement.cc
treewide: use seastar::format() or fmt::format() explicitly
2024-09-11 23:21:40 +03:00
function_statement.hh
…
grant_role_statement.hh
cql3: run auth DML writes on shard 0 and with raft guard
2024-03-01 16:25:14 +01:00
grant_statement.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
grant_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
index_prop_defs.cc
…
index_prop_defs.hh
…
index_target.cc
…
index_target.hh
…
ks_prop_defs.cc
network_topology_strategy/alter ks: Remove dc:s from options once rf=0
2025-04-18 14:09:52 +03:00
ks_prop_defs.hh
cql: join new and old KS options in ALTER tablets KS
2024-10-08 18:06:48 +00:00
list_effective_service_level_statement.cc
service/qos/sl_controller: use effective service levels cache
2024-08-08 10:42:09 +02:00
list_effective_service_level_statement.hh
cql3:statements: add LIST EFFECTIVE SERVICE LEVEL statement
2023-11-30 13:07:20 +01:00
list_permissions_statement.cc
auth: remove static from queries on auth-v2 path
2024-03-01 16:25:14 +01:00
list_permissions_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_roles_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_service_level_attachments_statement.cc
cql3: do not include unused headers
2024-01-16 16:43:17 +02:00
list_service_level_attachments_statement.hh
cql3: do not include unused headers
2024-01-16 16:43:17 +02:00
list_service_level_statement.cc
service/qos: increase timeout of internal get_service_levels queries
2024-12-16 14:15:26 +01:00
list_service_level_statement.hh
cql3: do not include unused headers
2024-01-16 16:43:17 +02:00
list_users_statement.cc
auth: remove static from queries on auth-v2 path
2024-03-01 16:25:14 +01:00
list_users_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
modification_statement.cc
treewide: use seastar::format() or fmt::format() explicitly
2024-09-11 23:21:40 +03:00
modification_statement.hh
cql3: define dtor of modification_statement in .cc file
2024-06-30 19:35:05 +03:00
permission_altering_statement.cc
cql3: do not include unused headers
2024-01-16 16:43:17 +02:00
permission_altering_statement.hh
cql3: run auth DML writes on shard 0 and with raft guard
2024-03-01 16:25:14 +01:00
prepared_statement.hh
cql3: Mark prepared_statement's fields const
2024-05-25 16:41:30 +03:00
property_definitions.cc
…
property_definitions.hh
cql: join new and old KS options in ALTER tablets KS
2024-10-08 18:06:48 +00:00
prune_materialized_view_statement.cc
treewide: include fmt/ranges.h and/or fmt/std.h
2024-04-19 22:56:16 +08:00
prune_materialized_view_statement.hh
…
request_validations.hh
cql3/statement: use compile-time format string
2024-07-28 21:54:43 +03:00
revoke_role_statement.hh
cql3: run auth DML writes on shard 0 and with raft guard
2024-03-01 16:25:14 +01:00
revoke_statement.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
revoke_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
role-management-statements.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
schema_altering_statement.cc
cql3: auth: move auto-grant closer to resource creation code
2024-06-07 10:26:32 +02:00
schema_altering_statement.hh
cql: remove global_req_id from schema_altering_statement
2024-06-18 20:26:09 +02:00
select_statement.cc
treewide: use seastar::format() or fmt::format() explicitly
2024-09-11 23:21:40 +03:00
select_statement.hh
replica/mutation_dump: enfore pinning of effective replication map
2024-08-22 06:24:06 -04:00
service_level_statement.cc
cql3:statements: run service level statements on shard0 with raft guard
2024-03-21 23:14:57 +01:00
service_level_statement.hh
cql3:statements: run service level statements on shard0 with raft guard
2024-03-21 23:14:57 +01:00
sl_prop_defs.cc
cql3: do not include unused headers
2024-01-16 16:43:17 +02:00
sl_prop_defs.hh
…
statement_type.hh
cql3: add formatter for cql3::statements::statement_type
2024-01-23 19:36:24 +02:00
strongly_consistent_modification_statement.cc
cql3: do not include unused headers
2024-01-16 16:43:17 +02:00
strongly_consistent_modification_statement.hh
cql3: do not include unused headers
2024-01-16 16:43:17 +02:00
strongly_consistent_select_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
strongly_consistent_select_statement.hh
cql3: do not include unused headers
2024-01-16 16:43:17 +02:00
truncate_statement.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
truncate_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
update_statement.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
update_statement.hh
…
use_statement.cc
use_statement: Covert an exception to a future exception
2023-11-09 10:43:11 +01:00
use_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00