mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-12 19:02:12 +00:00
" As part of avoiding static initialization order problems I want to switch a few global sstring to constexpr std::string_view. The advantage being that a constexpr variable doesn't need runtime initialization and therefore cannot be part of a static initialization order problem. In order to do the conversion I needed to convert a few APIs to use std::string_view instead of sstring and const sstring&. These patches are the simple cases that are also an improvement in their own right. " * 'espindola/string_view' of https://github.com/espindola/scylla: (22 commits) test: Pass a string_view to create_table's callback Pass string_view to the schema constructor cql3: Pass string_view to the column_specification constructor Pass string_view to keyspace_metadata::new_keyspace Pass string_view to the keyspace_metadata constructor utils: Use std::string as keys in nonstatic_class_registry utils: Pass a string_view to class_registry::to_qualified_class_name auth: Return a string_view from authorizer::qualified_java_name auth: Return a string_view from authenticator::qualified_java_name utils: Pass string_view to is_class_name_qualified test: Pass a string_view to create_keyspace Pass string_view to no_such_column_family's constructor perf_simple_query: Pass a string_view to make_counter_schema Pass string_view to the schema_builder constructor types: Add more data_value constructors transport: Pass a string_view to cql_server::connection::make_autheticate transport: Pass a string_view to cql_server::response::write_string cql3: Pass std::string_view to query_processor::compute_id cql3: Remove unused variable cql3: Pass a string_view to cf_statement::prepare_keyspace ...