Files
scylladb/types/collection.hh
Botond Dénes ba7a9d2ac3 imr: switch back to open-coded description of structures
Commit aab6b0ee27 introduced the
controversial new IMR format, which relied on a very template-heavy
infrastructure to generate serialization and deserialization code via
template meta-programming. The promise was that this new format, beyond
solving the problems the previous open-coded representation had (working
on linearized buffers), will speed up migrating other components to this
IMR format, as the IMR infrastructure reduces code bloat, makes the code
more readable via declarative type descriptions as well as safer.
However, the results were almost the opposite. The template
meta-programming used by the IMR infrastructure proved very hard to
understand. Developers don't want to read or modify it. Maintainers
don't want to see it being used anywhere else. In short, nobody wants to
touch it.

This commit does a conceptual revert of
aab6b0ee27. A verbatim revert is not
possible because related code evolved a lot since the merge. Also, going
back to the previous code would mean we regress as we'd revert the move
to fragmented buffers. So this revert is only conceptual, it changes the
underlying infrastructure back to the previous open-coded one, but keeps
the fragmented buffers, as well as the interface of the related
components (to the extent possible).

Fixes: #5578
2021-02-16 23:43:07 +01:00

123 lines
5.1 KiB
C++

/*
* Copyright (C) 2014 ScyllaDB
*/
/*
* This file is part of Scylla.
*
* Scylla is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Scylla is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
*/
#pragma once
#include <seastar/core/shared_ptr.hh>
#include <seastar/core/sstring.hh>
#include <vector>
#include "types.hh"
#include "collection_mutation.hh"
#include "utils/chunked_vector.hh"
#include "schema_fwd.hh"
namespace cql3 {
class column_specification;
}
class collection_type_impl : public abstract_type {
static logging::logger _logger;
public:
static constexpr size_t max_elements = 65535;
protected:
bool _is_multi_cell;
explicit collection_type_impl(kind k, sstring name, bool is_multi_cell)
: abstract_type(k, std::move(name), {}), _is_multi_cell(is_multi_cell) {}
public:
bool is_multi_cell() const { return _is_multi_cell; }
virtual data_type name_comparator() const = 0;
virtual data_type value_comparator() const = 0;
lw_shared_ptr<cql3::column_specification> make_collection_receiver(const cql3::column_specification& collection, bool is_key) const;
virtual bool is_compatible_with_frozen(const collection_type_impl& previous) const = 0;
virtual bool is_value_compatible_with_frozen(const collection_type_impl& previous) const = 0;
template <typename BytesViewIterator>
static bytes pack(BytesViewIterator start, BytesViewIterator finish, int elements, cql_serialization_format sf);
private:
// Explicitly instantiated in types.cc
template <FragmentedView View> data_value deserialize_impl(View v, cql_serialization_format sf) const;
public:
template <FragmentedView View> data_value deserialize(View v, cql_serialization_format sf) const {
if (v.size_bytes() == v.current_fragment().size()) [[likely]] {
return deserialize_impl(single_fragmented_view(v.current_fragment()), sf);
} else {
return deserialize_impl(v, sf);
}
}
template <FragmentedView View> data_value deserialize_value(View v, cql_serialization_format sf) const {
return deserialize(v, sf);
}
data_value deserialize(bytes_view v, cql_serialization_format sf) const {
return deserialize_impl(single_fragmented_view(v), sf);
}
data_value deserialize_value(bytes_view v, cql_serialization_format sf) const {
return deserialize_impl(single_fragmented_view(v), sf);
}
bytes_opt reserialize(cql_serialization_format from, cql_serialization_format to, bytes_view_opt v) const;
};
// a list or a set
class listlike_collection_type_impl : public collection_type_impl {
protected:
data_type _elements;
explicit listlike_collection_type_impl(kind k, sstring name, data_type elements,bool is_multi_cell);
public:
const data_type& get_elements_type() const { return _elements; }
// A list or set value can be serialized as a vector<pair<timeuuid, data_value>> or
// vector<pair<data_value, empty>> respectively. Compare this representation with
// vector<data_value> without transforming either of the arguments. Since Cassandra doesn't
// allow nested multi-cell collections this representation does not transcend to values, and we
// don't need to worry about recursing.
// @param this type of the listlike value represented as vector<data_value>
// @param map_type type of the listlike value represented as vector<pair<data_value, data_value>>
// @param list listlike value, represented as vector<data_value>
// @param map listlike value represented as vector<pair<data_value, data_value>>
//
// This function is used to compare receiver with a literal or parameter marker during condition
// evaluation.
int32_t compare_with_map(const map_type_impl& map_type, bytes_view list, bytes_view map) const;
// A list or set value can be represented as a vector<pair<timeuuid, data_value>> or
// vector<pair<data_value, empty>> respectively. Serialize this representation
// as a vector of values, not as a vector of pairs.
bytes serialize_map(const map_type_impl& map_type, const data_value& value) const;
};
template <typename BytesViewIterator>
bytes
collection_type_impl::pack(BytesViewIterator start, BytesViewIterator finish, int elements, cql_serialization_format sf) {
size_t len = collection_size_len(sf);
size_t psz = collection_value_len(sf);
for (auto j = start; j != finish; j++) {
len += j->size() + psz;
}
bytes out(bytes::initialized_later(), len);
bytes::iterator i = out.begin();
write_collection_size(i, elements, sf);
while (start != finish) {
write_collection_value(i, sf, *start++);
}
return out;
}