Avi Kivity 19a6e69001 cql3: accept and type-check reused named bind variables ...

A named bind-variable can be reused:

    SELECT * FROM tab
    WHERE a = :var AND b = :var

Currently, the grammar just ignores the possibility and creates
a new variable with the same name. The new variable cannot be
referenced by name since the first one shadows it.

Catch variable reuse by maintaining a map from bind variable names
to indexed, and check that when reusing a bind variable the types
match.

A unit test is added.

Fixes #10810

Closes #10813

2022-06-17 09:09:49 +02:00

..

expr

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

functions

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

restrictions

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

selection

cql3: expr: push is_satisfied_by regular and static column extraction to callers

2022-06-12 16:12:41 +03:00

statements

lwt: Cassandrda compatibility when incarnating a row for UPDATE

2022-06-16 19:23:46 +03:00

abstract_marker.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

abstract_marker.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

assignment_testable.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

attributes.cc

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

attributes.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

authorized_prepared_statements_cache.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

cf_name.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

cf_name.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

column_condition.cc

cql3::column_condition.cc: fix _in_marker handling The commit scylladb@5dee55d introduced a regression: type of in_list_receiver was taken from receiver instead of value_spec as it was before. This regression was caught by dtest test_lwt_update_prepared_listlike_and_tuples. This commit reverts to original behavior and adds a specific boost-test for this scenario.

2022-06-16 10:57:12 +03:00

column_condition.hh

cql3: column_condition: deinline constructor

2022-06-02 13:11:05 +03:00

column_identifier.cc

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

column_identifier.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

column_specification.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

column_specification.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

constants.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

constants.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

cql3_type.cc

cql3_type::raw_collection: handle unknown types first

2022-06-07 11:16:12 +02:00

cql3_type.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

cql_config.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

cql_statement.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

Cql.g

cql3: accept and type-check reused named bind variables

2022-06-17 09:09:49 +02:00

error_collector.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

error_listener.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

index_name.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

index_name.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

keyspace_element_name.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

keyspace_element_name.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

lists.cc

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

lists.hh

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

maps.cc

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

maps.hh

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

operation_impl.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

operation.cc

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

operation.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

prepare_context.cc

cql3: accept and type-check reused named bind variables

2022-06-17 09:09:49 +02:00

prepare_context.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

prepared_statements_cache.hh

code: Convert is_same+result_of assertions into invocable concepts

2022-02-24 19:46:10 +03:00

query_options_fwd.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

query_options.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

query_options.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

query_processor.cc

treewide: remove unqualified calls to std::move

2022-05-27 16:36:49 +02:00

query_processor.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

result_generator.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

result_set.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

result_set.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

role_name.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

role_name.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

role_options.hh

…

sets.cc

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

sets.hh

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

stats.hh

cql3: statements: introduce parallelized_select_statement

2022-02-01 21:14:41 +01:00

type_json.cc

CQL3: fromJson accepts string as bool

2022-03-04 14:18:34 +01:00

type_json.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

untyped_result_set.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

untyped_result_set.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

update_parameters.cc

lwt: Cassandrda compatibility when incarnating a row for UPDATE

2022-06-16 19:23:46 +03:00

update_parameters.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

user_types.cc

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

user_types.hh

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00

ut_name.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

ut_name.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

util.cc

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

util.hh

cql3: Remove relation class

2022-05-16 18:17:58 +02:00

values.cc

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

values.hh

cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant

2022-06-15 08:47:24 +02:00