mirror of
https://github.com/scylladb/scylladb.git
synced 2026-06-08 07:53:20 +00:00
79776ff2ff
A recent restructuring of the startup of Alternator (and also other protocol servers) led to incorrect error-handling behavior during startup: If an error was detected on one of the shards of the sharded service (in alternator/server.cc), the sharded service itself was never stopped (in alternator/controller.cc), leading to an assertion failure instead of the desired error message. A common example of this problem is when the requested port for the server was already taken (this was issue #9914). So in this patch, exception handling is removed from server.cc - the exception will propegate to the code in controller.cc, which will properly stop the server (including the sharded services) before returning. Fixes #9914. Signed-off-by: Nadav Har'El <nyh@scylladb.com> Message-Id: <20220130131709.1166716-1-nyh@scylladb.com>