63a2fed585
Commit5adb8e555cmarked the ::feed_hash() and a visitor lambda of digester::feed_hash() as noexcept. This was quite recklesl as the appending_hash<>::operator()s called by ::feed_hash() are not all marked noexcept. In particular, the appending_hash<row>() is not such and seem to throw. The original intent of the mentioned commit was to facilitate the partition_hasher in repair/ code. The hasher itself had been removed by the0af7a22c21, so it no longer needs the feed_hash-s to be noexcepts. The fix is to inherit noexcept from the called hashers, but for the digester::feed_hash part the noexcept is just removed until clang compilation bug #50994 is fixed. fixes: #8983 tests: unit(dev) Signed-off-by: Pavel Emelyanov <xemul@scylladb.com> Message-Id: <20210706153608.4299-1-xemul@scylladb.com>
83 lines
2.5 KiB
C++
83 lines
2.5 KiB
C++
/*
|
|
* Copyright (C) 2018-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "digest_algorithm.hh"
|
|
#include "hashers.hh"
|
|
#include "xx_hasher.hh"
|
|
|
|
#include <type_traits>
|
|
#include <variant>
|
|
|
|
namespace query {
|
|
|
|
struct noop_hasher {
|
|
void update(const char* ptr, size_t length) noexcept { }
|
|
std::array<uint8_t, 16> finalize_array() { return std::array<uint8_t, 16>(); };
|
|
};
|
|
|
|
class digester final {
|
|
std::variant<noop_hasher, md5_hasher, xx_hasher, legacy_xx_hasher_without_null_digest> _impl;
|
|
|
|
public:
|
|
explicit digester(digest_algorithm algo) {
|
|
switch (algo) {
|
|
case digest_algorithm::MD5:
|
|
_impl = md5_hasher();
|
|
break;
|
|
case digest_algorithm::xxHash:
|
|
_impl = xx_hasher();
|
|
break;
|
|
case digest_algorithm::legacy_xxHash_without_null_digest:
|
|
_impl = legacy_xx_hasher_without_null_digest();
|
|
break;
|
|
case digest_algorithm ::none:
|
|
_impl = noop_hasher();
|
|
break;
|
|
}
|
|
}
|
|
|
|
template<typename T, typename... Args>
|
|
void feed_hash(const T& value, Args&&... args) {
|
|
// FIXME uncomment the noexcept marking once clang bug 50994 is fixed or gcc compilation is turned on
|
|
std::visit([&] (auto& hasher) /* noexcept(noexcept(::feed_hash(hasher, value, args...))) */ -> void {
|
|
::feed_hash(hasher, value, std::forward<Args>(args)...);
|
|
}, _impl);
|
|
};
|
|
|
|
std::array<uint8_t, 16> finalize_array() {
|
|
return std::visit([&] (auto& hasher) {
|
|
return hasher.finalize_array();
|
|
}, _impl);
|
|
}
|
|
};
|
|
|
|
using default_hasher = xx_hasher;
|
|
|
|
template<typename Hasher>
|
|
using using_hash_of_hash = std::negation<std::disjunction<std::is_same<Hasher, md5_hasher>, std::is_same<Hasher, noop_hasher>>>;
|
|
|
|
template<typename Hasher>
|
|
inline constexpr bool using_hash_of_hash_v = using_hash_of_hash<Hasher>::value;
|
|
|
|
}
|