e0c7178e75
When executing internal queries, it is important that the developer will decide if to cache the query internally or not since internal queries are cached indefinitely. Also important is that the programmer will be aware if caching is going to happen or not. The code contained two "groups" of `query_processor::execute_internal`, one group has caching by default and the other doesn't. Here we add overloads to eliminate default values for caching behaviour, forcing an explicit parameter for the caching values. All the call sites were changed to reflect the original caching default that was there. Signed-off-by: Eliran Sinvani <eliransin@scylladb.com>
106 lines
3.3 KiB
C++
106 lines
3.3 KiB
C++
/*
|
|
* Copyright (C) 2018-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include "auth/roles-metadata.hh"
|
|
|
|
#include <boost/algorithm/cxx11/any_of.hpp>
|
|
#include <seastar/core/print.hh>
|
|
#include <seastar/core/shared_ptr.hh>
|
|
#include <seastar/core/sstring.hh>
|
|
|
|
#include "auth/common.hh"
|
|
#include "cql3/query_processor.hh"
|
|
#include "cql3/untyped_result_set.hh"
|
|
|
|
namespace auth {
|
|
|
|
namespace meta {
|
|
|
|
namespace roles_table {
|
|
|
|
std::string_view creation_query() {
|
|
static const sstring instance = fmt::format(
|
|
"CREATE TABLE {} ("
|
|
" {} text PRIMARY KEY,"
|
|
" can_login boolean,"
|
|
" is_superuser boolean,"
|
|
" member_of set<text>,"
|
|
" salted_hash text"
|
|
")",
|
|
qualified_name,
|
|
role_col_name);
|
|
|
|
return instance;
|
|
}
|
|
|
|
constexpr std::string_view qualified_name("system_auth.roles");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
future<bool> default_role_row_satisfies(
|
|
cql3::query_processor& qp,
|
|
std::function<bool(const cql3::untyped_result_set_row&)> p) {
|
|
static const sstring query = format("SELECT * FROM {} WHERE {} = ?",
|
|
meta::roles_table::qualified_name,
|
|
meta::roles_table::role_col_name);
|
|
|
|
return do_with(std::move(p), [&qp](const auto& p) {
|
|
return qp.execute_internal(
|
|
query,
|
|
db::consistency_level::ONE,
|
|
{meta::DEFAULT_SUPERUSER_NAME},
|
|
cql3::query_processor::cache_internal::yes).then([&qp, &p](::shared_ptr<cql3::untyped_result_set> results) {
|
|
if (results->empty()) {
|
|
return qp.execute_internal(
|
|
query,
|
|
db::consistency_level::QUORUM,
|
|
internal_distributed_query_state(),
|
|
{meta::DEFAULT_SUPERUSER_NAME},
|
|
cql3::query_processor::cache_internal::yes).then([&p](::shared_ptr<cql3::untyped_result_set> results) {
|
|
if (results->empty()) {
|
|
return make_ready_future<bool>(false);
|
|
}
|
|
|
|
return make_ready_future<bool>(p(results->one()));
|
|
});
|
|
}
|
|
|
|
return make_ready_future<bool>(p(results->one()));
|
|
});
|
|
});
|
|
}
|
|
|
|
future<bool> any_nondefault_role_row_satisfies(
|
|
cql3::query_processor& qp,
|
|
std::function<bool(const cql3::untyped_result_set_row&)> p) {
|
|
static const sstring query = format("SELECT * FROM {}", meta::roles_table::qualified_name);
|
|
|
|
return do_with(std::move(p), [&qp](const auto& p) {
|
|
return qp.execute_internal(
|
|
query,
|
|
db::consistency_level::QUORUM,
|
|
internal_distributed_query_state(),
|
|
cql3::query_processor::cache_internal::no).then([&p](::shared_ptr<cql3::untyped_result_set> results) {
|
|
if (results->empty()) {
|
|
return false;
|
|
}
|
|
|
|
static const sstring col_name = sstring(meta::roles_table::role_col_name);
|
|
|
|
return boost::algorithm::any_of(*results, [&p](const cql3::untyped_result_set_row& row) {
|
|
const bool is_nondefault = row.get_as<sstring>(col_name) != meta::DEFAULT_SUPERUSER_NAME;
|
|
return is_nondefault && p(row);
|
|
});
|
|
});
|
|
});
|
|
}
|
|
|
|
}
|