1ce73c2ab3
Fixes #9922
storage proxy uses is_timeout_exception to traverse different code paths.
a6202ae079 broke this (because bit rot and
intermixing), by wrapping exception for information purposes.
This adds check of nested types in exception handling, as well as a test
for the routine itself.
Closes #9932
* github.com:scylladb/scylla:
database/storage_proxy: Use "is_timeout_exception" instead of catch match
utils::is_timeout_exception: Ensure we handle nested exception types
76 lines
1.7 KiB
C++
76 lines
1.7 KiB
C++
/*
|
|
* Copyright 2015-present ScyllaDB
|
|
*/
|
|
|
|
/* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include <seastar/core/print.hh>
|
|
#include <seastar/rpc/rpc.hh>
|
|
#include <seastar/util/log.hh>
|
|
#include <seastar/util/backtrace.hh>
|
|
#include <seastar/core/abort_on_ebadf.hh>
|
|
|
|
#include <exception>
|
|
#include <system_error>
|
|
#include <atomic>
|
|
#include "exceptions.hh"
|
|
|
|
#include <iostream>
|
|
|
|
bool check_exception(system_error_lambda_t f)
|
|
{
|
|
auto e = std::current_exception();
|
|
if (!e) {
|
|
return false;
|
|
}
|
|
|
|
try {
|
|
std::rethrow_exception(e);
|
|
} catch (std::system_error &e) {
|
|
return f(e);
|
|
} catch (...) {
|
|
return false;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool is_system_error_errno(int err_no)
|
|
{
|
|
return check_exception([err_no] (const std::system_error &e) {
|
|
auto code = e.code();
|
|
return code.value() == err_no &&
|
|
code.category() == std::system_category();
|
|
});
|
|
}
|
|
|
|
bool should_stop_on_system_error(const std::system_error& e) {
|
|
if (e.code().category() == std::system_category()) {
|
|
// Whitelist of errors that don't require us to stop the server:
|
|
switch (e.code().value()) {
|
|
case EEXIST:
|
|
case ENOENT:
|
|
return false;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool is_timeout_exception(std::exception_ptr e) {
|
|
try {
|
|
std::rethrow_exception(e);
|
|
} catch (seastar::rpc::timeout_error& unused) {
|
|
return true;
|
|
} catch (seastar::semaphore_timed_out& unused) {
|
|
return true;
|
|
} catch (seastar::timed_out_error& unused) {
|
|
return true;
|
|
} catch (const std::nested_exception& e) {
|
|
return is_timeout_exception(e.nested_ptr());
|
|
} catch (...) {
|
|
}
|
|
return false;
|
|
}
|