mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-20 00:20:47 +00:00
f06c12e031
When using the set_routes with the registry builder, the shared_ptr of the registry builder should be captured. In the original implementation the api_registery_builder captured this parameter, but as the shared_ptr was not captured it was deleted, causing the http to crash when running in debug. In this implementation the method that use the registry creates a lambda function and inside it calls the set_api_doc method, this allows to catch the shared_ptr so it lives until the function complete. It also replaces the c style cast to static_cast and add a FIXME note to the routes implementation, that handlers should be deleted to prevent memory leak. Signed-off-by: Amnon Heiman <amnon@cloudius-systems.com>
90 lines
3.4 KiB
C++
90 lines
3.4 KiB
C++
/*
|
|
* This file is open source software, licensed to you under the terms
|
|
* of the Apache License, Version 2.0 (the "License"). See the NOTICE file
|
|
* distributed with this work for additional information regarding copyright
|
|
* ownership. You may not use this file except in compliance with the License.
|
|
*
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
/*
|
|
* Copyright 2015 Cloudius Systems
|
|
*/
|
|
|
|
#include "http/httpd.hh"
|
|
#include "http/handlers.hh"
|
|
#include "http/function_handlers.hh"
|
|
#include "http/file_handler.hh"
|
|
#include "apps/httpd/demo.json.hh"
|
|
#include "http/api_docs.hh"
|
|
|
|
namespace bpo = boost::program_options;
|
|
|
|
using namespace httpd;
|
|
|
|
class handl : public httpd::handler_base {
|
|
public:
|
|
virtual future<std::unique_ptr<reply> > handle(const sstring& path,
|
|
std::unique_ptr<request> req, std::unique_ptr<reply> rep) {
|
|
rep->_content = "hello";
|
|
rep->done("html");
|
|
return make_ready_future<std::unique_ptr<reply>>(std::move(rep));
|
|
}
|
|
};
|
|
|
|
void set_routes(routes& r) {
|
|
function_handler* h1 = new function_handler([](const_req req) {
|
|
return "hello";
|
|
});
|
|
function_handler* h2 = new function_handler([](std::unique_ptr<request> req) {
|
|
return make_ready_future<json::json_return_type>("json-future");
|
|
});
|
|
r.add(operation_type::GET, url("/"), h1);
|
|
r.add(operation_type::GET, url("/jf"), h2);
|
|
r.add(operation_type::GET, url("/file").remainder("path"),
|
|
new directory_handler("/"));
|
|
demo_json::hello_world.set(r,
|
|
[](const_req req) {
|
|
demo_json::my_object obj;
|
|
obj.var1 = req.param.at("var1");
|
|
obj.var2 = req.param.at("var2");
|
|
demo_json::ns_hello_world::query_enum v = demo_json::ns_hello_world::str2query_enum(req.query_parameters.at("query_enum"));
|
|
// This demonstrate enum conversion
|
|
obj.enum_var = v;
|
|
return obj;
|
|
});
|
|
}
|
|
|
|
int main(int ac, char** av) {
|
|
app_template app;
|
|
app.add_options()("port", bpo::value<uint16_t>()->default_value(10000),
|
|
"HTTP Server port");
|
|
return app.run(ac, av,
|
|
[&] {
|
|
auto&& config = app.configuration();
|
|
uint16_t port = config["port"].as<uint16_t>();
|
|
auto server = new http_server_control();
|
|
auto rb= make_shared<api_registry_builder>("apps/httpd/");
|
|
server->start().then([server] {
|
|
return server->set_routes(set_routes);
|
|
}).then([server, rb]{
|
|
return server->set_routes([rb](routes& r){rb->set_api_doc(r);});
|
|
}).then([server, rb]{
|
|
return server->set_routes([rb](routes& r) {rb->register_function(r, "demo", "hello world application");});
|
|
}).then([server, port] {
|
|
return server->listen(port);
|
|
}).then([port] {
|
|
std::cout << "Seastar HTTP server listening on port " << port << " ...\n";
|
|
});
|
|
|
|
});
|
|
}
|