mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-24 18:40:38 +00:00
fcce304908
The current code (this will change soon with my reactor patches) constructs a default (Posix) network stack before reactore::configure() reassigns it to the requested network stack. It turns out there is one place we use the network stack before calling reactore::configure(), which ends up using the Posix stack even though we want the native stack - this is both silly and plainly doesn't work on the OSv setup. The problem is that app_template.hh tries to configure scollectd before the engine is started. This calls scollectd::impl::start() which calls engine.net().make_udp_channel(). When this happens this early, it creates a Posix socket... This patch moves the scollectd configuration to after the engine is started. It makes sense to me: As far as I understand, scollectd is all about sending packets (diagnostic packets), and it's kind of silly to start sending packets before starting the machinary which allows us to send packets. Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com> [avi: use customary indentation, remove unneeded make_ready_future()]