ec77777bda
If any of the compared bytes_view's is empty consider the empty prefix is same and proceed to compare the size of the suffix. A similar issue exists in legacy_compound_view::tri_comparator::operator(). It too must not pass nullptr to memcmp if any of the compared byte_view's is empty. Fixes #6797 Refs #6814 Signed-off-by: Benny Halevy <bhalevy@scylladb.com> Test: unit(dev) Branches: all Message-Id: <20200709123453.955569-1-bhalevy@scylladb.com>
96 lines
2.6 KiB
C++
96 lines
2.6 KiB
C++
/*
|
|
* Copyright (C) 2015 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "seastarx.hh"
|
|
#include <seastar/core/sstring.hh>
|
|
#include "hashing.hh"
|
|
#include <optional>
|
|
#include <iosfwd>
|
|
#include <functional>
|
|
#include "utils/mutable_view.hh"
|
|
|
|
using bytes = basic_sstring<int8_t, uint32_t, 31, false>;
|
|
using bytes_view = std::basic_string_view<int8_t>;
|
|
using bytes_mutable_view = basic_mutable_view<bytes_view::value_type>;
|
|
using bytes_opt = std::optional<bytes>;
|
|
using sstring_view = std::string_view;
|
|
|
|
inline sstring_view to_sstring_view(bytes_view view) {
|
|
return {reinterpret_cast<const char*>(view.data()), view.size()};
|
|
}
|
|
|
|
namespace std {
|
|
|
|
template <>
|
|
struct hash<bytes_view> {
|
|
size_t operator()(bytes_view v) const {
|
|
return hash<sstring_view>()({reinterpret_cast<const char*>(v.begin()), v.size()});
|
|
}
|
|
};
|
|
|
|
}
|
|
|
|
bytes from_hex(sstring_view s);
|
|
sstring to_hex(bytes_view b);
|
|
sstring to_hex(const bytes& b);
|
|
sstring to_hex(const bytes_opt& b);
|
|
|
|
std::ostream& operator<<(std::ostream& os, const bytes& b);
|
|
std::ostream& operator<<(std::ostream& os, const bytes_opt& b);
|
|
|
|
namespace std {
|
|
|
|
// Must be in std:: namespace, or ADL fails
|
|
std::ostream& operator<<(std::ostream& os, const bytes_view& b);
|
|
|
|
}
|
|
|
|
template<>
|
|
struct appending_hash<bytes> {
|
|
template<typename Hasher>
|
|
void operator()(Hasher& h, const bytes& v) const {
|
|
feed_hash(h, v.size());
|
|
h.update(reinterpret_cast<const char*>(v.cbegin()), v.size() * sizeof(bytes::value_type));
|
|
}
|
|
};
|
|
|
|
template<>
|
|
struct appending_hash<bytes_view> {
|
|
template<typename Hasher>
|
|
void operator()(Hasher& h, bytes_view v) const {
|
|
feed_hash(h, v.size());
|
|
h.update(reinterpret_cast<const char*>(v.begin()), v.size() * sizeof(bytes_view::value_type));
|
|
}
|
|
};
|
|
|
|
inline int32_t compare_unsigned(bytes_view v1, bytes_view v2) {
|
|
auto size = std::min(v1.size(), v2.size());
|
|
if (size) {
|
|
auto n = memcmp(v1.begin(), v2.begin(), size);
|
|
if (n) {
|
|
return n;
|
|
}
|
|
}
|
|
return (int32_t) (v1.size() - v2.size());
|
|
}
|