Michał Chojnowski
dbddba0794
sstables/trie: actually apply BYPASS CACHE to index reads
...
BYPASS CACHE is implemented for `bti_index_reader` by
giving it its own private `cached_file` wrappers over
Partitions.db and Rows.db, instead of passing it
the shared `cached_file` owned by the sstable.
But due to an oversight, the private `cached_file`s aren't
constructed on top of the raw Partitions.db and Rows.db
files, but on top of `cached_file_impl` wrappers around
those files. Which means that BYPASS CACHE doesn't
actually do its job.
Tests based on `scylla_index_page_cache_*` metrics
and on CQL tracing still see the reads from the private
files as "cache misses", but those misses are served
from the shared cached files anyway, so the tests don't see
the problem. In this commit we extend `test_bti_index.py`
with a check that looks at reactor's `io_queue` metrics
instead, and catches the problem.
Fixes scylladb/scylladb#26372
Closes scylladb/scylladb#26373
2025-10-06 15:32:05 +03:00
..
2025-10-06 14:19:22 +02:00
2025-09-30 16:57:32 +03:00
2025-09-18 08:11:12 +03:00
2025-10-06 12:46:46 +02:00
2025-07-15 10:10:23 +03:00
2025-10-01 09:01:50 +02:00
2025-08-11 10:10:07 +08:00
2025-09-15 12:34:45 +02:00
2025-09-29 12:39:53 +02:00
2025-03-30 19:23:40 +03:00
2025-09-25 14:00:16 +03:00
2025-03-30 19:23:40 +03:00
2025-04-25 12:25:15 +02:00
2025-09-23 07:48:59 +02:00
2025-03-24 14:54:45 +02:00
2025-07-10 10:56:53 +08:00
2025-10-06 15:32:05 +03:00
2025-06-09 12:59:04 +02:00
2025-07-25 17:16:14 +02:00
2025-05-30 08:35:56 +02:00
2025-09-17 14:47:13 +02:00
2025-09-17 14:47:13 +02:00
2025-05-10 16:30:18 +02:00
2025-09-09 19:01:12 +02:00
2025-05-10 16:30:18 +02:00
2025-03-30 19:23:40 +03:00
2025-03-30 19:23:40 +03:00
2025-06-23 17:56:26 +02:00
2025-05-10 16:30:18 +02:00
2025-05-19 11:50:55 +00:00
2025-09-09 19:01:12 +02:00
2025-05-10 16:30:18 +02:00
2025-09-09 19:01:12 +02:00
2025-07-01 12:58:02 +02:00
2025-03-24 14:54:45 +02:00
2025-03-24 14:54:45 +02:00
2025-09-15 12:34:45 +02:00
2025-05-10 16:30:18 +02:00
2025-03-24 14:54:45 +02:00
2025-09-08 11:38:31 +02:00
2025-04-06 18:39:24 +03:00
2025-09-08 11:38:30 +02:00
2025-03-30 19:23:40 +03:00
2025-03-24 14:54:45 +02:00
2025-09-24 07:11:59 +02:00
2025-09-09 06:50:21 +03:00
2025-08-22 09:51:24 +03:00
2025-08-28 01:42:34 +02:00
2025-09-08 17:14:37 +02:00
2025-09-23 10:28:07 +03:00
2025-08-22 09:51:24 +03:00
2025-05-19 11:50:55 +00:00
2025-08-22 09:51:24 +03:00
2025-08-22 11:33:32 +02:00
2025-03-30 19:23:40 +03:00
2025-03-30 19:23:40 +03:00
2025-04-17 16:22:58 +02:00
2025-08-22 09:51:24 +03:00
2025-08-04 15:38:16 +03:00
2025-08-10 10:16:00 +02:00
2025-09-23 00:30:37 +02:00
2025-03-30 19:23:40 +03:00
2025-03-24 14:54:45 +02:00
2025-09-11 08:56:34 +03:00
2025-03-24 14:54:45 +02:00
2025-09-22 17:21:06 +02:00
2025-09-22 17:21:06 +02:00
2025-03-24 14:54:45 +02:00
2025-03-24 14:54:45 +02:00
2025-09-22 17:21:06 +02:00
2025-08-22 09:51:24 +03:00
2025-03-30 19:23:40 +03:00
2025-06-27 16:23:08 +03:00
2025-05-29 16:12:09 +03:00
2025-05-10 16:30:18 +02:00
2025-08-21 11:48:17 +03:00
2025-03-30 19:23:40 +03:00
2025-03-24 14:54:45 +02:00
2025-05-19 11:50:55 +00:00
2025-03-30 13:39:40 +03:00
2025-05-10 16:30:18 +02:00
2025-05-10 16:30:18 +02:00
2025-05-10 16:30:18 +02:00
2025-07-10 10:46:55 +02:00
2025-09-11 08:55:10 +03:00
2025-09-26 12:02:42 +03:00
2025-05-10 16:30:18 +02:00
2025-06-25 11:30:28 +03:00
2025-09-15 12:34:45 +02:00
2025-04-29 15:47:33 -03:00
2025-09-19 12:50:20 +03:00
2025-04-23 14:29:28 +02:00
2025-07-29 13:43:53 +08:00
2025-07-31 14:31:55 +03:00
2025-09-23 00:30:37 +02:00
2025-08-27 10:23:04 +02:00
2025-05-10 16:30:18 +02:00
2025-09-26 17:06:58 +02:00
2025-09-29 15:30:13 +03:00
2025-09-11 13:19:56 +02:00
2025-05-10 16:30:49 +02:00
2025-10-02 06:41:36 +03:00
2025-05-10 16:30:18 +02:00
2025-05-10 16:30:18 +02:00
2025-03-24 14:54:45 +02:00
2025-09-09 19:01:12 +02:00
2025-09-09 19:01:12 +02:00
2025-09-01 14:16:29 +02:00
2025-08-22 09:51:24 +03:00
2025-03-30 19:23:40 +03:00
2025-09-17 15:23:32 +05:30
2025-03-24 14:54:45 +02:00
2025-03-30 19:23:40 +03:00
2025-05-10 16:30:18 +02:00
2025-03-24 14:54:45 +02:00
2025-03-24 14:54:45 +02:00
2025-03-24 14:54:45 +02:00
2025-08-05 13:54:14 +02:00
2025-09-03 07:25:34 +03:00
2025-06-11 11:29:33 +03:00
2025-07-22 15:03:30 +02:00
2025-08-27 10:23:04 +02:00
2025-10-06 12:46:46 +02:00
2025-07-28 10:08:06 +02:00
2025-08-22 09:51:24 +03:00
2025-08-22 09:51:24 +03:00
2025-05-10 16:30:34 +02:00
2025-10-02 19:45:00 +02:00