1aacfdf460
The API req->param["name"] to access parameters in the path part of the URL was buggy - it forgot to do URL decoding and the result of our use of it in Scylla was bugs like #5883 - where special characters in certain REST API requests got botched up (encoded by the client, then not decoded by the server). The solution is to replace all uses of req->param["name"] by the new req->get_path_param("name"), which does the decoding correctly. Unfortunately we needed to change 104 (!) callers in this patch, but the transformation is mostly mechanical and there is no functional changes in this patch. Another set of changes was to bring req, not req->param, to a few functions that want to get the path param. This patch avoids the numerous deprecation warnings we had before, and more importantly, it fixes #5883. Signed-off-by: Nadav Har'El <nyh@scylladb.com>
85 lines
2.7 KiB
C++
85 lines
2.7 KiB
C++
/*
|
|
* Copyright (C) 2024-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include <seastar/core/coroutine.hh>
|
|
|
|
#include "api/api.hh"
|
|
#include "api/api-doc/raft.json.hh"
|
|
|
|
#include "service/raft/raft_group_registry.hh"
|
|
|
|
using namespace seastar::httpd;
|
|
|
|
extern logging::logger apilog;
|
|
|
|
namespace api {
|
|
|
|
namespace r = httpd::raft_json;
|
|
using namespace json;
|
|
|
|
void set_raft(http_context&, httpd::routes& r, sharded<service::raft_group_registry>& raft_gr) {
|
|
r::trigger_snapshot.set(r, [&raft_gr] (std::unique_ptr<http::request> req) -> future<json_return_type> {
|
|
raft::group_id gid{utils::UUID{req->get_path_param("group_id")}};
|
|
auto timeout_dur = std::invoke([timeout_str = req->get_query_param("timeout")] {
|
|
if (timeout_str.empty()) {
|
|
return std::chrono::seconds{60};
|
|
}
|
|
auto dur = std::stoll(timeout_str);
|
|
if (dur <= 0) {
|
|
throw std::runtime_error{"Timeout must be a positive number."};
|
|
}
|
|
return std::chrono::seconds{dur};
|
|
});
|
|
|
|
std::atomic<bool> found_srv{false};
|
|
co_await raft_gr.invoke_on_all([gid, timeout_dur, &found_srv] (service::raft_group_registry& raft_gr) -> future<> {
|
|
auto* srv = raft_gr.find_server(gid);
|
|
if (!srv) {
|
|
co_return;
|
|
}
|
|
|
|
found_srv = true;
|
|
abort_on_expiry aoe(lowres_clock::now() + timeout_dur);
|
|
apilog.info("Triggering Raft group {} snapshot", gid);
|
|
auto result = co_await srv->trigger_snapshot(&aoe.abort_source());
|
|
if (result) {
|
|
apilog.info("New snapshot for Raft group {} created", gid);
|
|
} else {
|
|
apilog.info("Could not create new snapshot for Raft group {}, no new entries applied", gid);
|
|
}
|
|
});
|
|
|
|
if (!found_srv) {
|
|
throw std::runtime_error{fmt::format("Server for group ID {} not found", gid)};
|
|
}
|
|
|
|
co_return json_void{};
|
|
});
|
|
r::get_leader_host.set(r, [&raft_gr] (std::unique_ptr<http::request> req) -> future<json_return_type> {
|
|
return smp::submit_to(0, [&] {
|
|
auto& srv = std::invoke([&] () -> raft::server& {
|
|
if (req->query_parameters.contains("group_id")) {
|
|
raft::group_id id{utils::UUID{req->get_query_param("group_id")}};
|
|
return raft_gr.local().get_server(id);
|
|
} else {
|
|
return raft_gr.local().group0();
|
|
}
|
|
});
|
|
return json_return_type(srv.current_leader().to_sstring());
|
|
});
|
|
});
|
|
}
|
|
|
|
void unset_raft(http_context&, httpd::routes& r) {
|
|
r::trigger_snapshot.unset(r);
|
|
r::get_leader_host.unset(r);
|
|
}
|
|
|
|
}
|
|
|