mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-26 19:35:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
ee113eca5279aff55dafeef7d98bcbc53dd159dc
scylladb/sstables
History
Raphael S. Carvalho 4c560b63f0 sstable: index_reader: Make sure streams are all properly closed on failure 
Turns out the fix f591c9c710 wasn't enough to make sure all input streams
are properly closed on failure.
It only closes the main input stream that belongs to context, but it misses
all the input streams that can be opened in the consumer for promote index
reading. Consumer stores a list of indexes, where each of them has its own
input stream. On failure, we need to make sure that every single one of
them is properly closed before destroying the indexes as that could cause
memory corruption due to read ahead.

Fixes #6924.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
Message-Id: <20200727182214.377140-1-raphaelsc@scylladb.com>
(cherry picked from commit 0d70efa58e)
2020-07-29 09:48:10 +03:00
..
mc
sstables: clamp estimated_partitions to [1, +inf) in writers
2020-07-27 15:00:00 +03:00
binary_search.hh
schema: get_partitioner return const&
2020-03-06 13:33:53 +01:00
checksum_utils.hh
treewide: update concepts language from the Concepts TS to C++20
2020-06-02 09:12:21 +03:00
column_name_helper.hh
header: De-bloat schema.hh
2020-03-03 11:34:00 +01:00
column_translation.hh
sstables: freeze types nested in collection types in legacy sstables
2020-04-16 18:44:56 +03:00
compaction_backlog_manager.hh
table: Fix Staging SSTables being incorrectly added or removed from the backlog tracker
2020-07-21 12:57:09 +03:00
compaction_descriptor.hh
compaction: add a new compaction type, Reshape
2020-06-18 09:37:18 -04:00
compaction_manager.cc
table: Fix Staging SSTables being incorrectly added or removed from the backlog tracker
2020-07-21 12:57:09 +03:00
compaction_manager.hh
compaction_manager: rename run_resharding_job
2020-06-18 09:00:27 -04:00
compaction_strategy_impl.hh
distributed_loader: reshard before the node is made online
2020-06-18 09:37:18 -04:00
compaction_strategy.cc
Merge 'view_update_generator: use partitioned sstable set'
2020-07-21 15:40:02 +03:00
compaction_weight_registration.hh
…
compaction.cc
sstables: clamp estimated_partitions to [1, +inf) in writers
2020-07-27 15:00:00 +03:00
compaction.hh
distributed_loader: reshard before the node is made online
2020-06-18 09:37:18 -04:00
component_type.hh
treewide: add missing headers and/or forward declarations
2020-03-23 09:29:45 +02:00
compress.cc
sstables: Pass an output_stream to make_compressed_file_.*_format_output_stream
2020-06-03 10:32:46 -07:00
compress.hh
sstables: Pass an output_stream to make_compressed_file_.*_format_output_stream
2020-06-03 10:32:46 -07:00
consumer.hh
sstables: consumer: Extract primitive_consumer
2020-06-16 16:14:30 +02:00
data_consume_context.hh
treewide: update concepts language from the Concepts TS to C++20
2020-06-02 09:12:21 +03:00
date_tiered_compaction_strategy.hh
sstables: date_tiered_compaction_strategy.hh: move methods out-of-line
2020-03-23 09:26:19 +02:00
disk_types.hh
…
downsampling.hh
treewide: add missing headers and/or forward declarations
2020-03-23 09:29:45 +02:00
exceptions.hh
treewide: add missing headers and/or forward declarations
2020-03-23 09:29:45 +02:00
filter.hh
treewide: add missing headers and/or forward declarations
2020-03-23 09:29:45 +02:00
hyperloglog.hh
treewide: add missing headers and/or forward declarations
2020-03-23 09:29:45 +02:00
index_entry.hh
sstables: clustered_index: Relax scope of validity of entry_info
2020-06-16 16:15:23 +02:00
index_reader.hh
sstable: index_reader: Make sure streams are all properly closed on failure
2020-07-29 09:48:10 +03:00
integrity_checked_file_impl.cc
…
integrity_checked_file_impl.hh
treewide: replace calls to engine().some_api() with some_api()
2020-04-05 12:46:04 +03:00
key.hh
header: De-bloat schema.hh
2020-03-03 11:34:00 +01:00
leveled_compaction_strategy.cc
reshape: LCS: avoid unnecessary work on level 0
2020-06-24 18:27:22 +03:00
leveled_compaction_strategy.hh
distributed_loader: reshard before the node is made online
2020-06-18 09:37:18 -04:00
leveled_manifest.hh
compaction: Enable tombstone expiration based on the presence of the sstable set
2020-06-07 11:46:48 +03:00
liveness_info.hh
…
m_format_read_helpers.cc
…
m_format_read_helpers.hh
sstables: print invalid boundary type as unsigned int
2020-04-07 10:18:19 +02:00
metadata_collector.hh
…
mp_row_consumer.cc
sstables: freeze types nested in collection types in legacy sstables
2020-04-16 18:44:56 +03:00
mp_row_consumer.hh
tombstone: use comparison operator instead of ad-hoc compare() function and with_relational_operators
2020-06-02 09:28:52 +03:00
mutation_fragment_filter.hh
sstables: mutation_fragment_filter: Drop unnecessary calls to _walker.out_of_range()
2019-06-19 14:29:02 +02:00
open_info.hh
sstables: move open-related structures to their own file.
2020-06-08 16:06:00 -04:00
partition.cc
treewide: update concepts language from the Concepts TS to C++20
2020-06-02 09:12:21 +03:00
prepended_input_stream.cc
…
prepended_input_stream.hh
…
progress_monitor.hh
sstables: Add write_failed to the write_monitor interface
2020-04-27 08:58:31 -07:00
random_access_reader.hh
treewide: add missing headers and/or forward declarations
2020-03-23 09:29:45 +02:00
remove.hh
treewide: add missing headers and/or forward declarations
2020-03-23 09:29:45 +02:00
row.hh
sstables: consumer: Extract primitive_consumer
2020-06-16 16:14:30 +02:00
scanning_clustered_index_cursor.hh
sstables: Abstract the clustering index cursor behavior
2020-06-16 16:14:17 +02:00
segmented_compress_params.hh
…
shareable_components.hh
…
shared_index_lists.hh
…
shared_sstable.hh
…
size_tiered_backlog_tracker.hh
sstables/backlog_tracker: Fix incorrect calculation of Compaction backlog
2020-06-18 13:56:47 +03:00
size_tiered_compaction_strategy.cc
compaction_strategy: add method to reshape SSTables
2020-06-18 09:37:18 -04:00
size_tiered_compaction_strategy.hh
compaction_strategy: add method to reshape SSTables
2020-06-18 09:37:18 -04:00
sstable_directory.cc
sstables/sstable_directory: improve log message in reshape()
2020-06-23 19:40:18 +03:00
sstable_directory.hh
distributed_loader: reenable verify_owner_and_mode when loading new sstables
2020-06-22 14:03:13 +03:00
sstable_set.hh
Merge 'view_update_generator: use partitioned sstable set'
2020-07-21 15:40:02 +03:00
sstable_version_k_l.hh
…
sstable_version_m.hh
…
sstable_version.cc
…
sstable_version.hh
…
sstables_manager.cc
sstables_manager: Keep format on
2020-05-25 14:17:28 +03:00
sstables_manager.hh
sstables_manager: Keep format on
2020-05-25 14:17:28 +03:00
sstables.cc
sstables: clamp estimated_partitions to [1, +inf) in writers
2020-07-27 15:00:00 +03:00
sstables.hh
Merge "Use binary search in sstable promoted index" from Tomasz
2020-06-18 12:09:39 +03:00
stats.hh
treewide: add missing headers and/or forward declarations
2020-03-23 09:29:45 +02:00
time_window_compaction_strategy.cc
compaction_strategy: add method to reshape SSTables
2020-06-18 09:37:18 -04:00
time_window_compaction_strategy.hh
compaction_strategy: add method to reshape SSTables
2020-06-18 09:37:18 -04:00
types.hh
sstables: Make deletion_time printable
2020-06-07 13:55:34 +03:00
version.hh
sstables: Move all_sstable_versions to version.hh
2020-04-17 11:34:02 +02:00
writer_impl.hh
header: De-bloat schema.hh
2020-03-03 11:34:00 +01:00
writer.hh
sstables: Pass a data_sink to checksummed_file_writer's constructor
2020-06-03 10:32:46 -07:00