scylladb

mirror of https://github.com/scylladb/scylladb.git synced 2026-04-19 16:15:07 +00:00

Files

Avi Kivity b9bc783418 cql3: selection: don't ignore regular column restriction if a regular row is not present

If a regular row isn't present, no regular column restriction
(say, r=3) can pass since all regular columns are presented as NULL,
and we don't have an IS NULL predicate. Yet we just ignore it.

Handle the restriction on a missing column by return false, signifying
the row was filtered out.

We have to move the check after the conditional checking whether there's
any restriction at all, otherwise we exit early with a false failure.

Unit test marked xfail on this issue are now unmarked.

A subtest of test_tombstone_limit is adjusted since it depended on this
bug. It tested a regular column which wasn't there, and this bug caused
the filter to be ignored. Change to test a static column that is there.

A test for a bug found while developing the patch is also added. It is
also tested by test_tombstone_limit, but better to have a dedicated test.

Fixes #10357

Closes scylladb/scylladb#20486

2024-09-15 13:44:16 +03:00

raw_selector.hh

cql3: selection: drop selector_factories, selectables, and selectors

2023-07-03 19:45:17 +03:00

selectable-expr.hh

cql3: do not include unused headers

2024-07-28 17:29:07 +03:00

selectable.cc

cql3: selection: drop selector_factories, selectables, and selectors

2023-07-03 19:45:17 +03:00

selection.cc

cql3: selection: don't ignore regular column restriction if a regular row is not present