mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-02 13:06:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
f4178f9582916085ffd73e296db365ea300a28cc
scylladb/tests
History
Nadav Har'El a0bc0d2d11 secondary index: fix support for compound partition key 
In the current code, if the base table has a compound partition key (i.e.,
multiple partition-key columns) searching its secondary indexes didn't work.
There is no real reason why this, it was a just a bug in preparing the
second query:

Every SI query is converted to two queries. The first queries the associated
materialized view, to find a list of primary keys. Those we need to use in a
second query, of the base table. The second query needs to list, as
restrictions, the keys found above. When a partition key is compound, its
components build one key and one restriction. But in the buggy code, we
incorrectly used each component as a separate (improperly formatted) key
and restriction, and obviously this didn't work.

This patch also adds a test that reproduces this problem and confirms its fix.

In the fixed code I also found another incorrect use of to_cql_string() (which
could break case-sensitive primary key column names) and changed it to
to_string().

Fixes #3210.

Signed-off-by: Nadav Har'El <nyh@scylladb.com>
Message-Id: <20180429124138.24406-1-nyh@scylladb.com>
2018-04-29 14:40:13 +01:00
..
perf
Fix Scylla to compile with older versions of JsonCpp (<= 1.7.0).
2018-04-24 10:58:38 +03:00
snitch_property_files
…
sstables
Add tests for writing data and index files in SSTables 3.0 ('mc') format.
2018-04-26 14:34:20 -07:00
aggregate_fcts_test.cc
tests: Tests for min/max aggregate functions over date/timestamp and timeuuid.
2018-01-14 13:17:09 +01:00
allocation_strategy_test.cc
build: support for linking statically with boost
2016-10-26 08:51:21 +03:00
anchorless_list_test.cc
build: support for linking statically with boost
2016-10-26 08:51:21 +03:00
auth_resource_test.cc
auth: Add code to expand a resource family
2018-02-14 14:15:59 -05:00
auth_test.cc
Don't store authenticated_user in shared_ptr
2018-02-14 14:15:58 -05:00
batchlog_manager_test.cc
cql3: query_processor: store and use just local shard reference of storage_proxy
2018-04-16 10:20:50 +02:00
big_decimal_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
bytes_ostream_test.cc
build: support for linking statically with boost
2016-10-26 08:51:21 +03:00
cache_flat_mutation_reader_test.cc
cache: Propagate cache_tracker to places manipulating evictable entries
2018-03-06 11:50:27 +01:00
caching_options_test.cc
tests: Add unit tests for caching_options.
2017-12-04 17:42:23 -08:00
canonical_mutation_test.cc
tests: reduce dependencies in test_services.hh
2018-03-12 20:05:23 +02:00
cartesian_product_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
castas_fcts_test.cc
tests: Add test that decimal obtained as CAST from integer always contain one decimal place.
2018-01-21 19:09:03 +01:00
cell_locker_test.cc
tests/cell_locker_test: Ensure timeout test finishes in useful time
2018-01-31 11:34:08 +01:00
chunked_vector_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
clustering_ranges_walker_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
commitlog_test.cc
Merge seastar upstream
2018-04-29 11:03:21 +03:00
compound_test.cc
tests: compound_test: fix the 'narrowing' compilation error on Power
2017-12-08 13:38:13 -05:00
compress_test.cc
sstables/compress: Fix race condition in segmented offset reading of shared sstable
2018-02-06 12:10:10 +02:00
config_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
continuous_data_consumer_test.cc
Merge seastar upstream
2018-04-29 11:03:21 +03:00
counter_test.cc
Swap arguments order of mutation constructor
2018-01-21 12:58:42 +02:00
cql_assertions.cc
tests/cql_assertions: Assert result set is not empty
2018-03-27 01:20:11 +01:00
cql_assertions.hh
tests/cql_assertions: Assert result set is not empty
2018-03-27 01:20:11 +01:00
cql_auth_query_test.cc
auth: Grant all permissions to object creator
2018-03-14 01:54:31 -04:00
cql_auth_syntax_test.cc
cql: Elaborate error for quoted user names
2018-03-01 12:06:59 -05:00
cql_query_test.cc
types: Make seastar::inet_address the "native" type for CQL inet.
2018-04-24 23:12:07 +01:00
cql_test_env.cc
tests/cql_test_env: Start the view_builder
2018-03-27 01:20:11 +01:00
cql_test_env.hh
tests/cql_test_env: Move eventually() to this file
2018-03-27 01:20:11 +01:00
crc_test.cc
utils::crc: introduce process_le/be(T) methods
2017-12-08 10:12:21 -05:00
database_test.cc
query-result: Introduce class result_options
2018-02-01 00:22:50 +00:00
duration_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
dynamic_bitset_test.cc
Merge seastar upstream
2018-04-29 11:03:21 +03:00
ec2_snitch_test.cc
locator: de-inline production_snitch_base
2018-03-11 18:22:49 +02:00
enum_set_test.cc
enum_set: Add iterator
2018-02-14 14:15:59 -05:00
extensions_test.cc
Extract sstable::component_type to separete header
2018-04-24 11:29:57 +02:00
failure_injecting_allocation_strategy.hh
tests: Move failure_injecting_allocation_strategy to a header
2017-11-28 12:38:28 +01:00
flat_mutation_reader_assertions.hh
tests: flat_reader_assertions: Improve failure message
2018-02-14 16:42:49 +01:00
flat_mutation_reader_test.cc
tests: reduce dependencies in test_services.hh
2018-03-12 20:05:23 +02:00
flush_queue_test.cc
tests/flush_queue_test: Don't assume continuations run immediately
2018-03-05 15:22:33 +02:00
frozen_mutation_test.cc
tests: reduce dependencies in test_services.hh
2018-03-12 20:05:23 +02:00
gce_snitch_test.cc
locator: de-inline production_snitch_base
2018-03-11 18:22:49 +02:00
gossip_test.cc
service/storage_service: Allow querying the view build status
2018-03-27 01:20:10 +01:00
gossip.cc
service/storage_service: Allow querying the view build status
2018-03-27 01:20:10 +01:00
gossiping_property_file_snitch_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
hash_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
hint_test.cc
tests: reduce dependencies in test_services.hh
2018-03-12 20:05:23 +02:00
idl_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
input_stream_test.cc
build: support for linking statically with boost
2016-10-26 08:51:21 +03:00
keys_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
limiting_data_source_test.cc
Add tests for make_limiting_data_source
2018-04-16 21:00:35 +02:00
loading_cache_test.cc
tests: close file correctly in loading_file_test
2018-03-19 12:16:11 +02:00
log_heap_test.cc
log_histogram: rename to log_heap
2017-09-18 12:44:05 +02:00
logalloc_test.cc
Merge seastar upstream
2018-04-29 11:03:21 +03:00
lsa_async_eviction_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
lsa_sync_eviction_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
make_random_string.hh
tests: simple_schema: Add missing include
2017-08-28 21:00:06 +02:00
managed_vector_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
map_difference_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
memory_footprint.cc
cache: Evict with row granularity
2018-03-06 11:50:29 +01:00
memtable_snapshot_source.hh
tests: Disable failure injection around background compactor
2018-02-14 16:42:49 +01:00
memtable_test.cc
Merge "Use xxHash for digest instead of MD5" from Duarte
2018-02-08 18:24:58 +02:00
message.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
murmur_hash_test.cc
build: support for linking statically with boost
2016-10-26 08:51:21 +03:00
mutation_assertions.hh
Delete unused streamed_mutation_assertions
2018-01-24 20:56:48 +01:00
mutation_diff
tests: Introduce mutation_diff script
2017-12-01 10:52:37 +01:00
mutation_fragment_test.cc
tests: reduce dependencies in test_services.hh
2018-03-12 20:05:23 +02:00
mutation_query_test.cc
Swap arguments order of mutation constructor
2018-01-21 12:58:42 +02:00
mutation_reader_test.cc
Add unit tests for multishard_combined_reader
2018-04-11 10:03:50 +03:00
mutation_source_test.cc
tests: mutation_source_test: Test reads with no clustering ranges and no static columns
2018-03-22 15:00:48 +01:00
mutation_source_test.hh
tests: mutation_source_test: Extract random_mutation_generator::make_partition_keys()
2017-12-22 11:06:33 +01:00
mutation_test.cc
cache: Propagate cache_tracker to places manipulating evictable entries
2018-03-06 11:50:27 +01:00
mvcc_test.cc
cache: Evict with row granularity
2018-03-06 11:50:29 +01:00
network_topology_strategy_test.cc
tests: network_topology_strategy_test: peel off redundant parentheses around token initializer
2018-04-21 13:53:29 +01:00
nonwrapping_range_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
partitioner_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
perf_row_cache_update.cc
Swap arguments order of mutation constructor
2018-01-21 12:58:42 +02:00
querier_cache.cc
test_resources_based_cache_eviction: s/assert/BOOST_REQUIRE_*/
2018-04-11 10:55:21 +03:00
query_processor_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
range_assert.hh
…
range_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
range_tombstone_list_assertions.hh
tests: Introduce range_tombstone_list assertions
2017-11-07 15:33:24 +01:00
range_tombstone_list_test.cc
tests: range_tombstone_list: Do not depend on argument evaluation order
2018-02-05 12:31:37 +00:00
result_set_assertions.cc
…
result_set_assertions.hh
…
role_manager_test.cc
auth: Remove unused "performer" argument
2018-02-14 14:15:58 -05:00
row_cache_alloc_stress.cc
tests: row_cache_alloc_stress: Avoid quadratic behavior
2018-03-07 16:52:59 +01:00
row_cache_stress_test.cc
row_cache: rename make_flat_reader to make_reader
2018-01-24 20:54:45 +01:00
row_cache_test.cc
Merge seastar upstream
2018-04-29 11:03:21 +03:00
row_locker_test.cc
Materialized views: test row_locker class
2018-01-30 16:19:43 +02:00
schema_change_test.cc
db: schema_tables: Treat drop of scylla_tables.version as an alter
2018-04-27 17:12:33 +03:00
schema_registry_test.cc
schema_tables: Require context object in schema load path
2018-02-07 10:11:46 +00:00
secondary_index_test.cc
secondary index: fix support for compound partition key
2018-04-29 14:40:13 +01:00
serialized_action_test.cc
tests/serialized_action_test: Don't rely on task execution order
2018-02-19 13:08:58 +00:00
simple_schema.hh
tests: simple_schema: Allow creating schema with no static column
2018-03-22 14:44:54 +01:00
snitch_reset_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
sstable_3_x_test.cc
Add tests for writing data and index files in SSTables 3.0 ('mc') format.
2018-04-26 14:34:20 -07:00
sstable_assertions.hh
Merge the pair of index_readers into just one tracking a range.
2018-03-29 15:23:31 +03:00
sstable_datafile_test.cc
A few improvements to encoding_stats structure.
2018-04-27 22:03:38 +03:00
sstable_mutation_test.cc
A few improvements to encoding_stats structure.
2018-04-27 22:03:38 +03:00
sstable_resharding_test.cc
Extract sstable::component_type to separete header
2018-04-24 11:29:57 +02:00
sstable_test.cc
Make data_consume_context a template
2018-04-26 12:49:37 +02:00
sstable_test.hh
Extract sstable::component_type to separete header
2018-04-24 11:29:57 +02:00
sstable_utils.cc
Remove unused mutation_reader_assertions
2018-01-24 20:56:48 +01:00
sstable_utils.hh
tests/sstable_utils: Inline make_local_key()
2018-01-17 12:17:17 +01:00
storage_proxy_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
streaming_histogram_test.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
test_services.hh
tests: reduce dependencies in test_services.hh
2018-03-12 20:05:23 +02:00
test-serialization.cc
Move thread_local declarations out of main.cc
2017-11-27 20:27:42 +01:00
tmpdir.hh
tests: move tmpdir to /tmp
2017-07-16 11:55:08 +02:00
total_order_check.hh
Remove to_boost_visitor heler.
2018-03-14 23:49:07 +00:00
types_test.cc
types: Make seastar::inet_address the "native" type for CQL inet.
2018-04-24 23:12:07 +01:00
UUID_test.cc
utils::UUID: operator< should behave as comparison of hex strings/bytes
2017-02-22 09:19:22 +00:00
view_build_test.cc
tests/view_build_test: Add tests for view building
2018-03-27 01:20:11 +01:00
view_complex_test.cc
tests: Add view_complex_test
2018-04-23 09:32:03 +01:00
view_schema_test.cc
Merge "Materialized views: Fixes to update generation" from Duarte
2018-04-23 16:49:29 +03:00
vint_serialization_test.cc
Cover serialized_size_from_first_byte in tests
2018-04-16 20:26:44 +02:00
virtual_reader_test.cc
tests: Add unit test for build_progress_virtual_reader
2018-03-27 01:20:10 +01:00