d698811bdd
Some packets, like arp replies, are broadcast to all cpus for handling, but only packet structure is copied for each cpu, the actual packet data is the same for all of them. Currently networking stack mangles a packet data during its travel up the stack while doing ntoh() translations which cannot obviously work for broadcaster packets. This patches fixes the code to not modify packet data while doing ntoh(), but do it in a stack allocated copy of a data instead.
55 lines
1.3 KiB
C++
55 lines
1.3 KiB
C++
/*
|
|
* Copyright (C) 2014 Cloudius Systems, Ltd.
|
|
*/
|
|
|
|
#include "arp.hh"
|
|
|
|
namespace net {
|
|
|
|
arp_for_protocol::arp_for_protocol(arp& a, uint16_t proto_num)
|
|
: _arp(a), _proto_num(proto_num) {
|
|
_arp.add(proto_num, this);
|
|
}
|
|
|
|
arp_for_protocol::~arp_for_protocol() {
|
|
_arp.del(_proto_num);
|
|
}
|
|
|
|
arp::arp(interface* netif) : _netif(netif), _proto(netif, eth_protocol_num::arp)
|
|
, _rx_packets(_proto.receive([this] (packet p, ethernet_address ea) {
|
|
return process_packet(std::move(p), ea);
|
|
},
|
|
[this](packet& p, size_t off) {
|
|
return handle_on_cpu(p, off);
|
|
})) {
|
|
}
|
|
|
|
unsigned arp::handle_on_cpu(packet& p, size_t off) {
|
|
auto ah = p.get_header<arp_hdr>(off);
|
|
auto i = _arp_for_protocol.find(ntoh(ah->ptype));
|
|
if (i != _arp_for_protocol.end()) {
|
|
return i->second->forward(p, off);
|
|
}
|
|
return engine.cpu_id();
|
|
}
|
|
|
|
void arp::add(uint16_t proto_num, arp_for_protocol* afp) {
|
|
_arp_for_protocol[proto_num] = afp;
|
|
}
|
|
|
|
void arp::del(uint16_t proto_num) {
|
|
_arp_for_protocol.erase(proto_num);
|
|
}
|
|
|
|
future<>
|
|
arp::process_packet(packet p, ethernet_address from) {
|
|
auto ah = ntoh(*p.get_header<arp_hdr>());
|
|
auto i = _arp_for_protocol.find(ah.ptype);
|
|
if (i != _arp_for_protocol.end()) {
|
|
i->second->received(std::move(p));
|
|
}
|
|
return make_ready_future<>();
|
|
}
|
|
|
|
}
|