mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-01 12:36:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
fae5a2a8c8ef7fe0a3ebbac70fa72070a04b17db
scylladb/tests
History
Nadav Har'El 85e5791710 tests/view_schema_test: fix flakiness caused by missing eventually() 
All tests that involve writing to a base table and then reading from the
view table must use the eventually() function to account for the fact that
the view update is asynchronous, and may be visible only some time after
writing the base table. Forgetting an eventually() can cause the test
to become flaky and sometimes fail because the expected data is not *yet*
in the view. Botond noticed these failures in practice in two subtests
(test_partition_key_filtering_with_slice and
test_clustering_key_in_restrictions).

This patch fixes both tests, and I also reviewed the entire source file
view_schem_test.cc and found additional places missing an eventually()
(and also places that unnecessarily used eventually() to read from the
base table), and fixed those as well.

Fixes #4212

Signed-off-by: Nadav Har'El <nyh@scylladb.com>
Message-Id: <20190212121140.14679-1-nyh@scylladb.com>
2019-02-12 16:10:30 +02:00
..
perf
Merge "Print a warning if a row is too large" from Rafael
2019-02-03 13:57:42 +02:00
snitch_property_files
…
sstables
sstable: handle missing index entry
2019-01-14 10:47:21 +01:00
aggregate_fcts_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
allocation_strategy_test.cc
…
anchorless_list_test.cc
…
auth_passwords_test.cc
…
auth_resource_test.cc
tests: convert sprint() to format()
2018-11-01 13:16:17 +00:00
auth_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
batchlog_manager_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
big_decimal_test.cc
…
broken_sstable_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
bytes_ostream_test.cc
…
cache_flat_mutation_reader_test.cc
Merge "Simpler fix for the memtable reader's fragment monotonicity violation" from Botond
2019-01-30 15:24:31 +00:00
caching_options_test.cc
…
canonical_mutation_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
cartesian_product_test.cc
…
castas_fcts_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
cell_locker_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
checksum_utils_test.cc
tests: Rename libdeflate_test to checksum_utils_test
2018-12-03 14:40:35 +01:00
chunked_vector_test.cc
…
clustering_ranges_walker_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
commitlog_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
compound_test.cc
…
compress_test.cc
…
config_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
continuous_data_consumer_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
counter_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
cql_assertions.cc
tests: convert sprint() to format()
2018-11-01 13:16:17 +00:00
cql_assertions.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
cql_auth_query_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
cql_auth_syntax_test.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
cql_query_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
cql_test_env.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
cql_test_env.hh
all: rename view_update_from_staging_generator
2019-01-15 17:31:47 +01:00
crc_test.cc
utils/crc: calculate crc in parallel
2018-11-01 10:19:32 +02:00
data_listeners_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
data_model.cc
tests/data_model: allow specifying timestamp for row markers
2019-02-07 10:16:50 +00:00
data_model.hh
tests/data_model: allow specifying timestamp for row markers
2019-02-07 10:16:50 +00:00
database_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
duration_test.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
dynamic_bitset_test.cc
…
ec2_snitch_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
enum_set_test.cc
…
eventually.hh
test: de-template eventually() and eventually_true()
2019-01-20 15:55:20 +02:00
extensions_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
failure_injecting_allocation_strategy.hh
…
filtering_test.cc
tests: add filtering with IN restriction test
2019-02-05 16:04:17 +01:00
flat_mutation_reader_assertions.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
flat_mutation_reader_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
flush_queue_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
fragmented_temporary_buffer_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
frozen_mutation_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
gce_snitch_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
gossip_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
gossip.cc
all: rename view_update_from_staging_generator
2019-01-15 17:31:47 +01:00
gossiping_property_file_snitch_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
hash_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
hint_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
idl_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
imr_test.cc
…
index_reader_assertions.hh
tests: convert sprint() to format()
2018-11-01 13:16:17 +00:00
input_stream_test.cc
…
json_cql_query_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
json_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
keys_test.cc
…
limiting_data_source_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
loading_cache_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
log_heap_test.cc
…
logalloc_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
lsa_async_eviction_test.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
lsa_sync_eviction_test.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
make_random_string.hh
…
managed_vector_test.cc
…
map_difference_test.cc
…
memory_footprint.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
memtable_snapshot_source.hh
flat_mutation_reader: make timeout opt-out rather than opt-in
2018-09-20 11:31:24 +02:00
memtable_test.cc
tests/memtable: test column tracking for encoding stats
2019-02-07 10:16:50 +00:00
message.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
meta_test.cc
…
multishard_mutation_query_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
multishard_writer_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
murmur_hash_test.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
mutation_assertions.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
mutation_diff
…
mutation_fragment_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
mutation_query_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
mutation_reader_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
mutation_source_test.cc
tests: extract mutation data model
2019-02-07 10:16:50 +00:00
mutation_source_test.hh
Revert "mutation_source_test: add option to skip intra-partition fast-forwarding tests"
2018-12-20 13:27:25 +00:00
mutation_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
mvcc_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
network_topology_strategy_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
nonwrapping_range_test.cc
…
normalizing_reader.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
normalizing_reader.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
observable_test.cc
…
partition_data_test.cc
…
partitioner_test.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
perf_row_cache_update.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
querier_cache.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
query_processor_test.cc
Merge "API: Stream compaction history records" from Amnon
2019-02-05 14:16:36 +02:00
random-utils.hh
tests: Add missing include in random-utils.hh
2018-12-19 10:52:19 +00:00
range_assert.hh
…
range_test.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
range_tombstone_list_assertions.hh
tests: convert sprint() to format()
2018-11-01 13:16:17 +00:00
range_tombstone_list_test.cc
tests: Fix use-after-free errors in static vars
2019-01-22 18:24:52 -05:00
result_set_assertions.cc
tests: convert sprint() to format()
2018-11-01 13:16:17 +00:00
result_set_assertions.hh
…
reusable_buffer_test.cc
…
role_manager_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
row_cache_alloc_stress.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
row_cache_stress_test.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
row_cache_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
row_locker_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
schema_change_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
schema_registry_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
secondary_index_test.cc
Merge "SI: Add virtual columns to underlying MV" from Duarte
2019-02-05 13:26:45 +02:00
serialized_action_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
simple_schema.hh
tests: convert sprint() to format()
2018-11-01 13:16:17 +00:00
small_vector_test.cc
utils/small_vector: fix leak in copy assignment slow path
2019-01-18 17:49:46 +02:00
snitch_reset_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
sstable_3_x_test.cc
sstable: write_components: drop default for encoding stats
2019-02-12 16:08:24 +02:00
sstable_datafile_test.cc
sstable: write_components: drop default for encoding stats
2019-02-12 16:08:24 +02:00
sstable_mutation_test.cc
sstable: write_components: drop default for encoding stats
2019-02-12 16:08:24 +02:00
sstable_resharding_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
sstable_run_based_compaction_strategy_for_tests.hh
tests: add example compaction strategy for sstable run based approach
2018-11-24 20:16:54 -02:00
sstable_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
sstable_test.hh
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
sstable_utils.cc
build: Remove unnecessary inclusion
2019-01-22 18:25:01 -05:00
sstable_utils.hh
Rename large_partition_handler
2019-01-28 15:03:14 -08:00
storage_proxy_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
streaming_histogram_test.cc
…
test_services.hh
…
test-serialization.cc
…
tmpdir.hh
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
top_k_test.cc
Merge "nodetool toppartitions" from Rafi & Avi
2018-12-28 16:31:24 +01:00
total_order_check.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
transport_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
types_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
utf8_test.cc
utils: optimize UTF-8 validation
2018-12-05 21:51:01 +02:00
UUID_test.cc
…
view_build_test.cc
Merge "Print a warning if a row is too large" from Rafael
2019-02-03 13:57:42 +02:00
view_complex_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
view_schema_test.cc
tests/view_schema_test: fix flakiness caused by missing eventually()
2019-02-12 16:10:30 +02:00
vint_serialization_test.cc
…
virtual_reader_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00