Calle Wilund 127606f788 cql_test_env/gossip: Prevent double shutdown call crash ...

Fixes #21159

When an exception is thrown in sstable write etc such that
storage_manager::isolate is initiated, we start a shutdown chain
for message service, gossip etc. These are synced (properly) in
storage_manager::stop, but if we somehow call gossiper::shutdown
outside the normal service::stop cycle, we can end up running the
method simultaneously, intertwined (missing the guard because of
the state change between check and set). We then end up co_awaiting
an invalid future (_failure_detector_loop_done) - a second wait.

Fixed by
a.) Remove superfluous gossiper::shutdown in cql_test_env. This was added
    in 20496ed, ages ago. However, it should not be needed nowadays.
b.) Ensure _failure_detector_loop_done is always waitable. Just to be sure.

(cherry picked from commit c28a5173d9)

Closes scylladb/scylladb#21393

2024-11-04 16:52:42 +01:00

..

application_state.cc

gms: remove unused operator<<

2024-06-18 15:55:22 +08:00

application_state.hh

gms: remove unused operator<<

2024-06-18 15:55:22 +08:00

CMakeLists.txt

build: bring abseil submodule back

2024-05-05 23:31:09 +03:00

endpoint_state.cc

treewide: support zero-token nodes in the recovery mode

2024-08-29 10:37:07 +02:00

endpoint_state.hh

gms: remove unused operator<<

2024-06-18 15:55:22 +08:00

feature_service.cc

features/config: Add feature for fragmented commitlog entries

2024-09-03 16:38:28 +00:00

feature_service.hh

message/messaging_service: guard adding maintenance tenant under cluster feature

2024-09-18 19:10:24 +02:00

feature.hh

gms: feature: mark when_enabled(func) with nodiscard

2024-03-27 08:55:45 +01:00

generation-number.cc

treewide: change assert() to SCYLLA_ASSERT()

2024-08-05 08:23:35 +03:00

generation-number.hh

gossiper: version_generator: add {debug_,}validate_gossip_generation

2023-04-23 08:48:01 +03:00

gossip_digest_ack2.cc

db: add formatter for gms::gossip_digest_ack2

2024-02-08 11:49:37 +02:00

gossip_digest_ack2.hh

gms: do not include unused headers

2024-04-05 08:48:17 +03:00

gossip_digest_ack.cc

gms: add add formatter for gms::gossip_*

2024-02-18 19:21:53 +02:00

gossip_digest_ack.hh

treewide: replace formatter<std::string_view> with formatter<string_view>

2024-04-19 07:44:07 +03:00

gossip_digest_syn.cc

gms: add add formatter for gms::gossip_*

2024-02-18 19:21:53 +02:00

gossip_digest_syn.hh

treewide: replace formatter<std::string_view> with formatter<string_view>

2024-04-19 07:44:07 +03:00

gossip_digest.hh

treewide: replace formatter<std::string_view> with formatter<string_view>

2024-04-19 07:44:07 +03:00

gossiper.cc

cql_test_env/gossip: Prevent double shutdown call crash

2024-11-04 16:52:42 +01:00

gossiper.hh

treewide: distinguish all nodes from all token owners

2024-08-29 10:37:07 +02:00

heart_beat_state.hh

gms: heart_beat_state: add formatter for gms::heart_beat_state

2024-01-09 11:52:40 +02:00

i_endpoint_state_change_subscriber.hh

endpoint_state subscriptions: batch on_change notification

2023-12-31 18:37:34 +02:00

inet_address_serializer.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

inet_address.cc

gms: remove unused operator<<

2024-06-18 15:55:22 +08:00

inet_address.hh

gms: remove unused operator<<

2024-06-18 15:55:22 +08:00

version_generator.cc

version_generator: check that get_next_version is called on shard 0

2024-02-23 13:49:49 +01:00

version_generator.hh

gms: version_generator: define version_type and generation_type strong types

2023-04-23 08:47:17 +03:00

versioned_value.cc

gossiper: remove unused REMOVAL_COORDINATOR state

2024-02-19 15:01:33 +02:00

versioned_value.hh

gms: remove unused operator<<

2024-06-18 15:55:22 +08:00