d568270d7f
" Commitd0f9e00changed the representation of the gc_clock::duration from int32_t to int64_t. Mutation hashing uses appending_hash<gc_clock::time_point>, which by default feeds duration::count() into the hasher. duration::rep changed from int32_t to int64_t, which changes the value of the hash. This affects schema digest and query digests, resulting in mismatches between nodes during a rolling upgrade. Fixes #4460. Refs #4485. " * tag 'fix-gc_clock-digest-v2.1' of github.com:tgrabiec/scylla: tests: Add test which verifies that schema digest stays the same tests: Add sstables for the schema digest test schema_tables, storage_service: Make schema digest insensitive to expired tombstones in empty partition db/schema_tables: Move feed_hash_for_schema_digest() to .cc file hashing: Introduce type-erased interface for the hasher hashing: Introduce C++ concept for the hasher hashers: Rename hasher to cryptopp_hasher gc_clock: Fix hashing to be backwards-compatible (cherry picked from commit82b91c1511)
52 lines
1.5 KiB
C++
52 lines
1.5 KiB
C++
/*
|
|
* Copyright (C) 2019 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "bytes.hh"
|
|
#include "hashing.hh"
|
|
|
|
class md5_hasher;
|
|
|
|
template <typename T, size_t size> class cryptopp_hasher : public hasher {
|
|
struct impl;
|
|
std::unique_ptr<impl> _impl;
|
|
|
|
public:
|
|
cryptopp_hasher();
|
|
~cryptopp_hasher();
|
|
cryptopp_hasher(cryptopp_hasher&&) noexcept;
|
|
cryptopp_hasher(const cryptopp_hasher&);
|
|
cryptopp_hasher& operator=(cryptopp_hasher&&) noexcept;
|
|
cryptopp_hasher& operator=(const cryptopp_hasher&);
|
|
|
|
bytes finalize();
|
|
std::array<uint8_t, size> finalize_array();
|
|
void update(const char* ptr, size_t length) override;
|
|
|
|
// Use update and finalize to compute the hash over the full view.
|
|
static bytes calculate(const std::string_view& s);
|
|
};
|
|
|
|
class md5_hasher final : public cryptopp_hasher<md5_hasher, 16> {};
|
|
|
|
class sha256_hasher final : public cryptopp_hasher<sha256_hasher, 32> {};
|