mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-24 02:20:37 +00:00
5597bc8573
when using ":attrs" attribute' from Nadav Har'El This PR improves the testing for issue #5009 and fixes most of it (but not all - see below). Issue #5009 is about what happens when a user tries to use the name `:attrs` for an attribute - while Alternator uses a map column with that name to hold all the schema-less attributes of an item. The tests we had for this issue were partial, and missed the worst cases which could result in Scylla crashing on specially-crafted PutItem or UpdateItem requests. What the tests missed were the cases that `:attrs` is used as a **non-key**. So in this PR we add additional tests for this case, several of them fail or even crash Scylla, and then we fix all these cases. Issue #5009 remains open because using `:attrs` as the name of a **key** is still not allowed. But because it results in a clean error message when attempting to create a table with such a key, I consider this remaining problem very minor. Refs #5009. Closes #11572 * github.com:scylladb/scylladb: alternator: fix crashes an errors when using ":attrs" attribute alternator: improve tests for reserved attribute name ":attrs"