Duarte Nunes 7ba944a243
service/migration_manager: Validate duplicate ID in time ...
We allow tables to be created with the ID property, mostly for
advanced recovery cases. However, we need to validate that the ID
doesn't match an existing one. We currently do this in
database::add_column_family(), but this is already too late in the
normal workflow: if we allow the schema change to go through, then
it is applied to the system tables and loaded the next time the node
boots, regardless of us throwing from database::add_column_family().
To fix this, we perform this validation when announcing a new table.
Note that the check wasn't removed from database::add_column_family();
it's there since 2015 and there might have been other reasons to add
it that are not related to the ID property.
Refs #2059
Signed-off-by: Duarte Nunes <duarte@scylladb.com >
Message-Id: <20181001230142.46743-1-duarte@scylladb.com >
2018-10-02 13:40:40 +03:00
2018-09-20 11:31:24 +02:00
2018-09-25 17:55:52 -07:00
2018-09-28 09:45:27 +02:00
2018-09-12 12:14:21 +01:00
2018-02-14 14:15:59 -05:00
2018-05-14 09:41:06 +03:00
2018-05-31 15:51:11 +01:00
2018-06-25 09:21:47 +01:00
2018-06-27 21:51:04 +02:00
2018-03-12 20:05:23 +02:00
2018-06-25 09:21:47 +01:00
2018-06-19 16:26:52 +03:00
2018-09-18 17:22:59 +01:00
2018-02-06 12:10:10 +02:00
2018-04-29 11:03:21 +03:00
2018-05-31 15:51:11 +01:00
2018-09-17 20:35:55 +03:00
2018-09-17 20:35:55 +03:00
2018-03-14 01:54:31 -04:00
2018-03-01 12:06:59 -05:00
2018-10-02 13:40:40 +03:00
2018-06-14 14:24:01 +01:00
2018-08-27 19:24:00 +01:00
2018-06-26 18:54:44 +02:00
2018-04-29 11:03:21 +03:00
2018-03-11 18:22:49 +02:00
2018-02-14 14:15:59 -05:00
2018-08-27 19:24:05 +01:00
2018-04-24 11:29:57 +02:00
2018-05-09 16:52:26 +01:00
2018-09-25 18:02:46 -07:00
2018-09-28 14:27:55 +03:00
2018-03-05 15:22:33 +02:00
2018-09-18 17:22:59 +01:00
2018-09-20 11:31:24 +02:00
2018-03-11 18:22:49 +02:00
2018-08-14 12:27:14 +01:00
2018-03-27 01:20:10 +01:00
2018-09-18 17:22:59 +01:00
2018-06-15 09:56:45 +01:00
2018-08-01 16:50:58 +01:00
2018-07-20 13:51:13 -07:00
2018-07-25 13:16:06 +02:00
2018-05-28 18:12:12 +03:00
2018-04-16 21:00:35 +02:00
2018-09-05 10:19:59 +03:00
2018-06-11 15:34:14 +03:00
2018-06-11 15:34:14 +03:00
2018-05-31 15:51:11 +01:00
2018-09-20 11:31:24 +02:00
2018-09-20 11:31:24 +02:00
2018-07-17 20:15:32 +08:00
2018-05-31 10:09:01 +01:00
2018-09-12 11:43:18 +01:00
2018-09-20 11:31:24 +02:00
2018-09-03 10:31:44 +03:00
2018-07-17 16:32:04 +03:00
2018-09-20 11:31:24 +02:00
2018-09-06 20:54:57 +03:00
2018-09-20 11:31:24 +02:00
2018-09-20 11:31:24 +02:00
2018-06-28 17:20:28 +08:00
2018-09-20 11:31:24 +02:00
2018-06-27 21:51:04 +02:00
2018-04-21 13:53:29 +01:00
2018-09-26 19:24:10 -07:00
2018-09-25 17:55:52 -07:00
2018-07-11 10:15:01 +01:00
2018-05-31 15:51:11 +01:00
2018-09-20 11:31:24 +02:00
2018-09-03 10:31:44 +03:00
2018-07-18 12:28:06 +01:00
2018-02-05 12:31:37 +00:00
2018-07-18 12:28:06 +01:00
2018-02-14 14:15:58 -05:00
2018-09-20 11:31:24 +02:00
2018-09-20 11:31:24 +02:00
2018-09-20 11:31:24 +02:00
2018-05-22 16:52:58 +02:00
2018-04-27 17:12:33 +03:00
2018-02-07 10:11:46 +00:00
2018-09-27 15:29:28 +02:00
2018-02-19 13:08:58 +00:00
2018-05-31 15:51:11 +01:00
2018-09-25 17:55:52 -07:00
2018-09-25 18:02:46 -07:00
2018-09-26 21:48:32 +01:00
2018-06-25 09:37:43 +01:00
2018-09-25 17:55:52 -07:00
2018-09-25 18:02:46 -07:00
2018-05-04 14:38:13 +02:00
2018-06-28 17:20:28 +08:00
2018-03-12 20:05:23 +02:00
2018-03-14 23:49:07 +00:00
2018-07-18 12:28:06 +01:00
2018-04-24 23:12:07 +01:00
2018-07-26 12:03:37 +01:00
2018-03-27 01:20:11 +01:00
2018-09-17 00:38:55 +01:00
2018-08-16 15:51:46 +03:00
2018-04-16 20:26:44 +02:00
2018-06-04 11:31:29 +01:00
7ba944a243