fdeb14b468
There was two more things missing: * Allow global options to be positioned before the operation/command option (https://github.com/scylladb/scylladb/issues/16695) * Ignore JVM args (https://github.com/scylladb/scylladb/issues/16696) This PR fixes both. With this, hopefully we are fully compatible with nodetool as far as command line parsing is concerned. After this PR goes in, we will need another fix to tools/java/bin/nodetool-wrapper, to allow user to benefit from this fix. Namely, after this PR, we can just try to invoke scylla-nodetool first with all the command-line args as-is. If it returns with exit-code 100, we fall back to nodetool. We will not need the current trick with `--help $1`. In fact, this trick doesn't work currently, because `$1` is not guaranteed to be the command in the first place. In addition to the above, this PR also introduces a new option, to help us in the switching process. This is `--rest-api-port`, which can also be provided as `-Dcom.scylladb.apiPort`. When provided, this option takes precedence over `--port|-p`. This is intended as a bridge for `scylla-ccm`, which currently provides the JMX port as `--port`. With this change, it can also provided the REST API port as `-Dcom.scylladb.apiPort`. The legacy nodetool will ignore this, while the native nodetool will use it to connect to the correct REST API address. After the switch we can ditch these options. Fixes: https://github.com/scylladb/scylladb/issues/16695 Fixes: https://github.com/scylladb/scylladb/issues/16696 Refs: https://github.com/scylladb/scylladb/issues/16679 Refs: https://github.com/scylladb/scylladb/issues/15588 Closes scylladb/scylladb#17168 * github.com:scylladb/scylladb: tools/scylla-nodetool: add --rest-api-port option tools/scylla-nodetool: ignore JVM args tools/utils: make finding the operation command line option more flexible tools/utils: get_selected_operation(): remove alias param tools: add constant with current help command-line arguments
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cql-pytest - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.