7bb41b50f9
It is safe to copy column_mapping accros shards. Such guarantee comes at
the cost of performance.
This patch makes commitlog_entry_writer use IDL generated writer to
serialise commitlog_entry so that column_mapping is not copied. This
also simplifies commitlog_entry itself.
Performance difference tested with:
perf_simple_query -c4 --write --duration 60
(medians)
before after diff
write 79434.35 89247.54 +12.3%
(cherry picked from commit 374c8a56ac)
Also: Fixes #2468.
88 lines
2.4 KiB
C++
88 lines
2.4 KiB
C++
/*
|
|
* Copyright 2016 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <experimental/optional>
|
|
|
|
#include "frozen_mutation.hh"
|
|
#include "schema.hh"
|
|
#include "utils/data_output.hh"
|
|
|
|
namespace stdx = std::experimental;
|
|
|
|
class commitlog_entry {
|
|
stdx::optional<column_mapping> _mapping;
|
|
frozen_mutation _mutation;
|
|
public:
|
|
commitlog_entry(stdx::optional<column_mapping> mapping, frozen_mutation&& mutation)
|
|
: _mapping(std::move(mapping)), _mutation(std::move(mutation)) { }
|
|
const stdx::optional<column_mapping>& mapping() const { return _mapping; }
|
|
const frozen_mutation& mutation() const { return _mutation; }
|
|
};
|
|
|
|
class commitlog_entry_writer {
|
|
schema_ptr _schema;
|
|
const frozen_mutation& _mutation;
|
|
bool _with_schema = true;
|
|
size_t _size;
|
|
private:
|
|
template<typename Output>
|
|
void serialize(Output&) const;
|
|
void compute_size();
|
|
public:
|
|
commitlog_entry_writer(schema_ptr s, const frozen_mutation& fm)
|
|
: _schema(std::move(s)), _mutation(fm)
|
|
{
|
|
compute_size();
|
|
}
|
|
|
|
void set_with_schema(bool value) {
|
|
_with_schema = value;
|
|
compute_size();
|
|
}
|
|
bool with_schema() {
|
|
return _with_schema;
|
|
}
|
|
schema_ptr schema() const {
|
|
return _schema;
|
|
}
|
|
|
|
size_t size() const {
|
|
return _size;
|
|
}
|
|
|
|
size_t mutation_size() const {
|
|
return _mutation.representation().size();
|
|
}
|
|
|
|
void write(data_output& out) const;
|
|
};
|
|
|
|
class commitlog_entry_reader {
|
|
commitlog_entry _ce;
|
|
public:
|
|
commitlog_entry_reader(const temporary_buffer<char>& buffer);
|
|
|
|
const stdx::optional<column_mapping>& get_column_mapping() const { return _ce.mapping(); }
|
|
const frozen_mutation& mutation() const { return _ce.mutation(); }
|
|
};
|