mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-22 01:20:39 +00:00
9ebd6df43a
We're reducing the log level in case the provided property file is incomplete. The rationale behind this change is related to how CCM interacts with Scylla: * The `GossipingPropertyFileSnitch` reloads the `cassandra-rackdc.properties` configuration every 60 seconds. * When a new node is added to the cluster, CCM recreates the `cassandra-rackdc.properties` file for EVERY node. If those two processes start happening at about the same time, it may lead to Scylla trying to read a not-completely-recreated file, and an error will be produced. Although we would normally fix this issue and try to avoid the race, that behavior will be no longer relevant as we're making the rack and DC values immutable (cf. scylladb/scylladb#23278). What's more, trying to fix the problem in the older versions of Scylla could bring a more serious regression. Having that in mind, this commit is a compromise between making CI less flaky and having minimal impact when backported. We do the same for when the format of the file is invalid: the rationale is the same. We also do that for when there is a double declaration. Although it seems impossible that this can stem from the same scenario the other two errors can (since if the format of the file is valid, the error is justified; if the format is invalid, it should be detected sooner than a doubled declaration), let's stay consistent with the logging level. Fixes scylladb/scylladb#20092 Closes scylladb/scylladb#23956