mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-03 13:37:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
scylla-4.6.9
scylladb/utils
History
Nadav Har'El cbcfa31e51 cql: validate bloom_filter_fp_chance up-front 
Scylla's Bloom filter implementation has a minimal false-positive rate
that it can support (6.71e-5). When setting bloom_filter_fp_chance any
lower than that, the compute_bloom_spec() function, which writes the bloom
filter, throws an exception. However, this is too late - it only happens
while flushing the memtable to disk, and a failure at that point causes
Scylla to crash.

Instead, we should refuse the table creation with the unsupported
bloom_filter_fp_chance. This is also what Cassandra did six years ago -
see CASSANDRA-11920.

This patch also includes a regression test, which crashes Scylla before
this patch but passes after the patch (and also passes on Cassandra).

Fixes #11524.

Signed-off-by: Nadav Har'El <nyh@scylladb.com>

Closes #11576

(cherry picked from commit 4c93a694b7)
2022-10-04 16:23:25 +03:00
..
arch/powerpc/crc32-vpmsum
utils: crc32: mark power crc32 assembly as not requiring an executable stack
2018-10-02 18:48:23 +01:00
gz
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
lsa
utils/chunked_managed_vector: Fix sigsegv during reserve()
2022-04-13 10:29:30 +03:00
allocation_strategy.hh
build: enable -Winconsistent-missing-override warning
2021-09-15 12:55:54 +03:00
anchorless_list.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
array-search.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
array-search.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
ascii.cc
utils: add fast ascii string validation
2018-12-24 09:58:08 +02:00
ascii.hh
utils: add fast ascii string validation
2018-12-24 09:58:08 +02:00
atomic_vector.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
base64.cc
utils,alternator: move base64 code from alternator to utils
2021-08-09 09:24:36 +02:00
base64.hh
utils: untie rjson.hh from base64.hh
2021-10-05 12:57:54 +02:00
big_decimal.cc
utils: big_decimal: change to std::strong_ordering
2021-07-28 13:28:21 +03:00
big_decimal.hh
utils: big_decimal: change to std::strong_ordering
2021-07-28 13:28:21 +03:00
bit_cast.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
bloom_calculations.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
bloom_calculations.hh
cql: validate bloom_filter_fp_chance up-front
2022-10-04 16:23:25 +03:00
bloom_filter.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
bloom_filter.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
bounded_stats_deque.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
bptree.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
buffer_input_stream.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
buffer_input_stream.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
build_id.cc
utils: convert fmt::fprintf() to fmt::print()
2021-10-27 17:02:00 +03:00
build_id.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cached_file.hh
Merge 'utils: cached_file: Fix alloc-dealloc mismatch during eviction' from Tomasz Grabiec
2022-02-26 11:28:53 +02:00
chunked_vector.hh
utils/chunked_vector: Fix sigsegv during reserve()
2022-04-13 10:29:03 +03:00
class_registrator.hh
abstract_replication_strategy: use shared_ptr in registry
2021-10-13 12:39:36 +03:00
clmul.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
coarse_steady_clock.hh
rename coarse_clock to coarse_steady_clock
2021-08-02 17:41:21 +03:00
collection-concepts.hh
util: Drop int_or_strong_ordering concept
2021-06-08 11:40:55 +03:00
compact-radix-tree.hh
utils: compact-radix-tree: fix accidental cache line bouncing
2021-08-26 17:22:22 +03:00
config_file_impl.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
config_file.cc
everywhere: cleanup defer.hh includes
2021-08-22 21:11:39 +03:00
config_file.hh
everywhere: cleanup defer.hh includes
2021-08-22 21:11:39 +03:00
coroutine.hh
utils/coroutine: wrap a helper in utils namespace
2021-07-22 13:28:43 +03:00
crc.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cross-shard-barrier.hh
utils: Introduce cross-shard barrier (with test)
2021-09-15 17:35:12 +03:00
data_input.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
date.h
…
directories.cc
distributed_loader, utils: Move verify_owner_and_mode
2021-10-11 11:03:51 +03:00
directories.hh
distributed_loader, utils: Move verify_owner_and_mode
2021-10-11 11:03:51 +03:00
disk-error-handler.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
disk-error-handler.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
div_ceil.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
double-decker.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
dynamic_bitset.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
dynamic_bitset.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
entangled.hh
lsa: Introduce entangled helper
2021-07-02 19:02:13 +02:00
enum_option.hh
utils/enum_option.hh: add implicit converter to the underlying enum
2021-06-13 13:18:49 +03:00
error_injection.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
error_injection.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
estimated_histogram.hh
utils/estimated_histogram.hh: fix division-by-zero in mean()
2021-10-28 08:58:25 +03:00
exceptions.cc
utils: exceptions: is_timeout_exception: add timed_out_error
2021-07-08 15:23:29 +03:00
exceptions.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
exponential_backoff_retry.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
extremum_tracking.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
fb_utilities.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
file_lock.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
file_lock.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
flush_queue.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
fragment_range.hh
utils: fragment_range: change to std::strong_ordering
2021-07-28 13:27:49 +03:00
fragmented_temporary_buffer.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
generation-number.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
generation-number.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
hash.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
histogram_metrics_helper.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
histogram.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
human_readable.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
human_readable.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
i_filter.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
i_filter.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
immutable-collection.hh
range_tombstone_list: add lower_slice
2021-11-02 10:50:31 +01:00
in.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
input_stream.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
int_range.hh
utils: int_range: change to std::strong_ordering
2021-07-28 13:29:50 +03:00
intrusive_btree.hh
btree: Add commens in .clone() and .clear()
2021-08-31 12:36:54 +03:00
intrusive-array.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
joinpoint.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
large_bitset.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
large_bitset.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
latency.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
like_matcher.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
like_matcher.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
limiting_data_source.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
limiting_data_source.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
linearizing_input_stream.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
loading_cache.hh
loading_cache: Make invalidation take immediate effect
2022-05-04 15:38:11 +03:00
loading_shared_values.hh
loading_cache: Make invalidation take immediate effect
2022-05-04 15:38:11 +03:00
log_heap.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
logalloc.cc
Merge 'utils: cached_file: Fix alloc-dealloc mismatch during eviction' from Tomasz Grabiec
2022-02-26 11:28:53 +02:00
logalloc.hh
logalloc: count evicted memory
2021-08-01 19:34:13 +03:00
lru.hh
row_cache: Use generic LRU for eviction
2021-07-02 10:25:58 +02:00
managed_bytes.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
managed_bytes.hh
managed_bytes: avoid compile-time loop in converting constructor
2021-10-10 18:16:50 +03:00
managed_ref.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
managed_vector.hh
sstables: Cache partition index pages in LSA and link to LRU
2021-07-02 19:02:14 +02:00
maybe_yield.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
memory_data_sink.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
multiprecision_int.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
multiprecision_int.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
murmur_hash.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
murmur_hash.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
mutable_view.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
neat-object-id.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
observable.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
overloaded_functor.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
phased_barrier.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
preempt.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
ranges.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
rate_limiter.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
rate_limiter.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
reusable_buffer.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
rjson.cc
rjson, alternator: rename set() functions add()
2021-11-04 16:35:38 +01:00
rjson.hh
rjson, alternator: rename set() functions add()
2021-11-04 16:35:38 +01:00
runtime.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
runtime.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sequenced_set.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
serialization.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
serialized_action.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
small_vector.hh
utils/small_vector: remove noexcept from the copy constructor, which potentially throws
2021-09-15 12:55:54 +03:00
stall_free.hh
utils: stall_free: implemnt clear_gently of froeign_ptr
2021-07-01 19:16:11 +03:00
streaming_histogram.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
top_k.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
updateable_value.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
updateable_value.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
utf8.cc
utils/utf8.c: move includes outside of namespaces
2021-05-30 23:23:20 +03:00
utf8.hh
utils: fragment_range: add a fragment iterator for FragmentedView
2021-01-15 14:05:44 +01:00
UUID_gen.cc
utils: UUID_gen: introduce negate()
2021-09-09 11:49:05 +03:00
UUID_gen.hh
utils: UUID_gen: introduce negate()
2021-09-09 11:49:05 +03:00
uuid.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
UUID.hh
uuid: change comparators to std::strong_ordering
2021-07-28 13:20:32 +03:00
variant_element.hh
utils: introduce variant_element.hh
2021-07-27 20:08:47 +03:00
vle.hh
uleb64: Add express encoding
2021-06-16 17:47:10 +03:00