From 2c305f9e7f637ef2c17dadf206571834cf76c884 Mon Sep 17 00:00:00 2001 From: pingqiu Date: Fri, 3 Apr 2026 09:17:11 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20CP13-8=20=E2=80=94=20use=20correct=20ass?= =?UTF-8?q?ert=20params=20+=20add=20pgbench=20TPS=20gate?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. assert_contains: change actual/expected to value/contains (matches the action implementation in system.go) 2. Add assert_greater for pgbench TPS > 0 after pgbench_run (closes the pgbench durability pass criterion in the doc) Co-Authored-By: Claude Opus 4.6 (1M context) --- .../internal/cp13-8-real-workload-validation.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/weed/storage/blockvol/testrunner/scenarios/internal/cp13-8-real-workload-validation.yaml b/weed/storage/blockvol/testrunner/scenarios/internal/cp13-8-real-workload-validation.yaml index c0b5c84f5..9e7bd24d8 100644 --- a/weed/storage/blockvol/testrunner/scenarios/internal/cp13-8-real-workload-validation.yaml +++ b/weed/storage/blockvol/testrunner/scenarios/internal/cp13-8-real-workload-validation.yaml @@ -186,8 +186,8 @@ phases: cmd: "md5sum /mnt/cp13-8/file_* | sort > /tmp/cp13-8-checksums-post.txt && diff /tmp/cp13-8-checksums.txt /tmp/cp13-8-checksums-post.txt && echo MATCH" save_as: checksum_match - action: assert_contains - actual: "{{ checksum_match }}" - expected: "MATCH" + value: "{{ checksum_match }}" + contains: "MATCH" - action: umount node: client_node mountpoint: /mnt/cp13-8 @@ -216,7 +216,10 @@ phases: save_as: tps_post_failover - action: print msg: "CP13-8: pgbench TPC-B post-failover: {{ tps_post_failover }} TPS" - # pgbench succeeded = database transactions are durable on the promoted replica. + - action: assert_greater + value: "{{ tps_post_failover }}" + threshold: "0" + # pgbench succeeded with TPS > 0 = database transactions are durable on the promoted replica. - action: pgbench_cleanup node: client_node mount: "/mnt/cp13-8-pg"