From 2e9b944e5c2ea137c726d4bb296a48651243daea Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Wed, 22 Jul 2026 21:37:59 -0700 Subject: [PATCH] test(s3): aim collection force-delete at the master the suite actually runs (#10404) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The copying and tagging tests force-drop each bucket's collection at the master so volume slots are freed deterministically between tests. But the copy-tests CI job runs its master on 9336 and the tagging Makefile on 9338, while the tests default to 9333 — the cleanup dialed a dead port and quietly no-oped. Each test bucket then grows 7 volumes against -volume.max=100, and whenever async deletion lagged the data node ran out of slots and PutObject 500ed with "No writable volumes and no free volumes left". Set MASTER_ENDPOINT where the master port is non-default: the copy-tests workflow step, and the copying/tagging Makefiles (derived from MASTER_PORT). --- .github/workflows/s3tests.yml | 2 +- test/s3/copying/Makefile | 3 +++ test/s3/tagging/Makefile | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/s3tests.yml b/.github/workflows/s3tests.yml index 15bf6e023..980ca20dd 100644 --- a/.github/workflows/s3tests.yml +++ b/.github/workflows/s3tests.yml @@ -765,7 +765,7 @@ jobs: sleep 2 done - go test -v + MASTER_ENDPOINT="http://127.0.0.1:9336" go test -v kill -9 $pid || true # Clean up data directory rm -rf "$WEED_DATA_DIR" || true diff --git a/test/s3/copying/Makefile b/test/s3/copying/Makefile index afc510b67..ea399223f 100644 --- a/test/s3/copying/Makefile +++ b/test/s3/copying/Makefile @@ -13,6 +13,9 @@ ACCESS_KEY ?= some_access_key1 SECRET_KEY ?= some_secret_key1 VOLUME_MAX_SIZE_MB ?= 50 +# Let the tests force-drop collections at the master they actually run against +export MASTER_ENDPOINT ?= http://127.0.0.1:$(MASTER_PORT) + # Test directory TEST_DIR := $(shell pwd) SEAWEEDFS_ROOT := $(shell cd ../../../ && pwd) diff --git a/test/s3/tagging/Makefile b/test/s3/tagging/Makefile index 0ae7b1518..fbadb4ead 100644 --- a/test/s3/tagging/Makefile +++ b/test/s3/tagging/Makefile @@ -12,6 +12,9 @@ FILER_PORT := 8893 TEST_TIMEOUT := 10m TEST_PATTERN := TestObjectTaggingOnUpload|TestPutObjectTaggingAPI|TestDeleteObjectTagging|TestTag +# Let the tests force-drop collections at the master they actually run against +export MASTER_ENDPOINT ?= http://127.0.0.1:$(MASTER_PORT) + # Default target help: @echo "S3 Object Tagging Tests Makefile"