From 696aa04cc24cf89d3c87a71790e165c103fa7c3f Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Thu, 8 Oct 2026 07:09:39 -0700 Subject: [PATCH] test: verify the recorded PID is weed before stopping it A prerequisite failure leaves a stale weed-server.pid in place; the PID may have been reused by an unrelated process. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- test/s3/error_compat/Makefile | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/s3/error_compat/Makefile b/test/s3/error_compat/Makefile index 759820d1ba..e9b697d193 100644 --- a/test/s3/error_compat/Makefile +++ b/test/s3/error_compat/Makefile @@ -76,9 +76,12 @@ start-server: check-deps stop-server: @if [ -f weed-server.pid ]; then \ - echo "Stopping SeaweedFS server..."; \ - kill $$(cat weed-server.pid) 2>/dev/null || true; \ - sleep 2; \ + pid=$$(cat weed-server.pid); \ + if ps -p $$pid -o comm= 2>/dev/null | grep -q weed; then \ + echo "Stopping SeaweedFS server..."; \ + kill $$pid 2>/dev/null || true; \ + sleep 2; \ + fi; \ rm -f weed-server.pid; \ fi