From 913f98db10ec03f72def58fb8f35b8ac440c91b9 Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Fri, 1 May 2026 11:52:40 -0700 Subject: [PATCH] refactor(weed/storage): log volume file removal failures (#9297) --- weed/storage/volume_write.go | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/weed/storage/volume_write.go b/weed/storage/volume_write.go index e78bb2b3a..6aa267829 100644 --- a/weed/storage/volume_write.go +++ b/weed/storage/volume_write.go @@ -89,20 +89,26 @@ func (v *Volume) Destroy(onlyEmpty bool) (err error) { func removeVolumeFiles(filename string) { // basic - os.Remove(filename + ".dat") - os.Remove(filename + ".idx") - os.Remove(filename + ".vif") + deleteAndLog := func(ext string) { + fullFilename := filename + "." + ext + if err := os.RemoveAll(fullFilename); err != nil { + glog.V(0).Infof("failed to remove volume file %s: %s", fullFilename, err) + } + } + deleteAndLog("dat") + deleteAndLog("idx") + deleteAndLog("vif") // sorted index file - os.Remove(filename + ".sdx") + deleteAndLog("sdx") // compaction - os.Remove(filename + ".cpd") - os.Remove(filename + ".cpx") + deleteAndLog("cpd") + deleteAndLog("cpx") // level db index file - os.RemoveAll(filename + ".ldb") + deleteAndLog("ldb") // redb index file (Rust volume server) - os.Remove(filename + ".rdb") + deleteAndLog("rdb") // marker for damaged or incomplete volume - os.Remove(filename + ".note") + deleteAndLog("note") } func (v *Volume) asyncRequestAppend(request *needle.AsyncRequest) {